Chromium Code Reviews

Unified Diff: src/objects.cc

Issue 133683002: Retry "Templatise type representation" after making clang happy (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « src/objects.h ('k') | src/property-details.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index dcbe21198c76faf39014d66ec08787d5ea9103da..46be0bde3eaf978ae5162d64a9edaa1e6c6e2f27 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -10543,13 +10543,12 @@ void Code::FindAllTypes(TypeHandleList* types) {
ASSERT(is_inline_cache_stub());
DisallowHeapAllocation no_allocation;
int mask = RelocInfo::ModeMask(RelocInfo::EMBEDDED_OBJECT);
- Isolate* isolate = GetIsolate();
for (RelocIterator it(this, mask); !it.done(); it.next()) {
RelocInfo* info = it.rinfo();
Object* object = info->target_object();
if (object->IsMap()) {
Handle<Map> map(Map::cast(object));
- types->Add(handle(IC::MapToType(map), isolate));
+ types->Add(IC::MapToType(map));
}
}
}
@@ -16605,9 +16604,8 @@ Handle<Type> PropertyCell::UpdatedType(Handle<PropertyCell> cell,
Handle<Type> old_type(cell->type(), isolate);
// TODO(2803): Do not track ConsString as constant because they cannot be
// embedded into code.
- Handle<Type> new_type(value->IsConsString() || value->IsTheHole()
- ? Type::Any()
- : Type::Constant(value, isolate), isolate);
+ Handle<Type> new_type = value->IsConsString() || value->IsTheHole()
+ ? Type::Any(isolate) : Type::Constant(value, isolate);
if (new_type->Is(old_type)) {
return old_type;
@@ -16620,7 +16618,7 @@ Handle<Type> PropertyCell::UpdatedType(Handle<PropertyCell> cell,
return new_type;
}
- return handle(Type::Any(), isolate);
+ return Type::Any(isolate);
}
« no previous file with comments | « src/objects.h ('k') | src/property-details.h » ('j') | no next file with comments »

Powered by Google App Engine