Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336763008: [Chromecast] Replace test ASSERT to fix compilation errors. (Closed)

Created:
5 years, 3 months ago by bcf_google
Modified:
5 years, 3 months ago
Reviewers:
slan, gunsch
CC:
chromium-reviews, kalyank, lcwu+watch_chromium.org, sadrul, halliwell+watch_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Replace test ASSERT to fix compilation errors. BUG=internal b/19210655 Committed: https://crrev.com/51c8f6fd366277375d2069dfd08cee6c336cc513 Cr-Commit-Position: refs/heads/master@{#348748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chromecast/crash/linux/synchronized_minidump_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bcf_google
Sorry forgot to run CQ on https://codereview.chromium.org/1310313004/ ... This fixes arm compilation of that CL. ...
5 years, 3 months ago (2015-09-14 22:22:18 UTC) #2
gunsch
weird, looks like CQ did run and passed but we don't do an arm/gcc based ...
5 years, 3 months ago (2015-09-14 22:23:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336763008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336763008/1
5 years, 3 months ago (2015-09-14 22:26:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 22:40:47 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51c8f6fd366277375d2069dfd08cee6c336cc513 Cr-Commit-Position: refs/heads/master@{#348748}
5 years, 3 months ago (2015-09-14 22:41:44 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:22 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/51c8f6fd366277375d2069dfd08cee6c336cc513
Cr-Commit-Position: refs/heads/master@{#348748}

Powered by Google App Engine
This is Rietveld 408576698