Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager_unittest.cc

Issue 1336763008: [Chromecast] Replace test ASSERT to fix compilation errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
diff --git a/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc b/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
index d65a96840cb8fb3ac84ecb682fdf41a5e2ff0a29..1fa62afbe3c9f3e6cce29b3f829a10a423a3f994 100644
--- a/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
+++ b/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
@@ -181,7 +181,7 @@ void produce_dumps(SynchronizedMinidumpManagerSimple& producer, int num_dumps) {
void consume_dumps(FakeSynchronizedMinidumpUploader& consumer, int num_dumps) {
for (int i = 0; i < num_dumps; ++i) {
ASSERT_EQ(0, consumer.DoWorkLocked());
- ASSERT_EQ(true, consumer.can_upload_return_val());
+ ASSERT_TRUE(consumer.can_upload_return_val());
}
}
@@ -464,7 +464,7 @@ TEST_F(SynchronizedMinidumpManagerTest, Upload_FailsWhenTooManyRecentDumps) {
// Should fail with too many dumps
ASSERT_EQ(0, uploader.DoWorkLocked());
- ASSERT_EQ(false, uploader.can_upload_return_val());
+ ASSERT_FALSE(uploader.can_upload_return_val());
}
TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) {
@@ -487,7 +487,7 @@ TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) {
// Should fail with too many dumps
ASSERT_EQ(0, uploader.DoWorkLocked());
- ASSERT_EQ(false, uploader.can_upload_return_val());
+ ASSERT_FALSE(uploader.can_upload_return_val());
int64 period = SynchronizedMinidumpManager::kRatelimitPeriodSeconds;
@@ -495,7 +495,7 @@ TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) {
produce_dumps(producer, 1);
SetRatelimitPeriodStart(metadata_.value(), now - period / 2);
ASSERT_EQ(0, uploader.DoWorkLocked());
- ASSERT_EQ(false, uploader.can_upload_return_val());
+ ASSERT_FALSE(uploader.can_upload_return_val());
// Set period starting time to trigger a reset
SetRatelimitPeriodStart(metadata_.value(), now - period);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698