Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: chromecast/crash/linux/synchronized_minidump_manager_unittest.cc

Issue 1336763008: [Chromecast] Replace test ASSERT to fix compilation errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <fcntl.h> 5 #include <fcntl.h>
6 #include <stdlib.h> 6 #include <stdlib.h>
7 #include <sys/file.h> 7 #include <sys/file.h>
8 #include <sys/stat.h> // mkdir 8 #include <sys/stat.h> // mkdir
9 #include <sys/types.h> // 9 #include <sys/types.h> //
10 #include <stdio.h> // perror 10 #include <stdio.h> // perror
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 ASSERT_EQ(0, producer.DoWorkLocked()); 174 ASSERT_EQ(0, producer.DoWorkLocked());
175 ASSERT_EQ(0, producer.add_entry_return_code()); 175 ASSERT_EQ(0, producer.add_entry_return_code());
176 } 176 }
177 } 177 }
178 178
179 // Have |consumer| remove and process |num_dumps| while checking there are no 179 // Have |consumer| remove and process |num_dumps| while checking there are no
180 // errors. 180 // errors.
181 void consume_dumps(FakeSynchronizedMinidumpUploader& consumer, int num_dumps) { 181 void consume_dumps(FakeSynchronizedMinidumpUploader& consumer, int num_dumps) {
182 for (int i = 0; i < num_dumps; ++i) { 182 for (int i = 0; i < num_dumps; ++i) {
183 ASSERT_EQ(0, consumer.DoWorkLocked()); 183 ASSERT_EQ(0, consumer.DoWorkLocked());
184 ASSERT_EQ(true, consumer.can_upload_return_val()); 184 ASSERT_TRUE(consumer.can_upload_return_val());
185 } 185 }
186 } 186 }
187 187
188 } // namespace 188 } // namespace
189 189
190 TEST_F(SynchronizedMinidumpManagerTest, FilePathsAreCorrect) { 190 TEST_F(SynchronizedMinidumpManagerTest, FilePathsAreCorrect) {
191 SynchronizedMinidumpManagerSimple manager; 191 SynchronizedMinidumpManagerSimple manager;
192 192
193 // Verify file paths for directory and lock file. 193 // Verify file paths for directory and lock file.
194 ASSERT_EQ(minidump_dir_.value(), manager.dump_path()); 194 ASSERT_EQ(minidump_dir_.value(), manager.dump_path());
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 SynchronizedMinidumpManagerSimple producer; 457 SynchronizedMinidumpManagerSimple producer;
458 producer.SetDumpInfoToWrite( 458 producer.SetDumpInfoToWrite(
459 make_scoped_ptr(new DumpInfo("dump1", "log1", now, params))); 459 make_scoped_ptr(new DumpInfo("dump1", "log1", now, params)));
460 460
461 const int max_dumps = SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps; 461 const int max_dumps = SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps;
462 produce_dumps(producer, max_dumps + 1); 462 produce_dumps(producer, max_dumps + 1);
463 consume_dumps(uploader, max_dumps); 463 consume_dumps(uploader, max_dumps);
464 464
465 // Should fail with too many dumps 465 // Should fail with too many dumps
466 ASSERT_EQ(0, uploader.DoWorkLocked()); 466 ASSERT_EQ(0, uploader.DoWorkLocked());
467 ASSERT_EQ(false, uploader.can_upload_return_val()); 467 ASSERT_FALSE(uploader.can_upload_return_val());
468 } 468 }
469 469
470 TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) { 470 TEST_F(SynchronizedMinidumpManagerTest, UploadSucceedsAfterRateLimitPeriodEnd) {
471 // Sample parameters. 471 // Sample parameters.
472 time_t now = time(0); 472 time_t now = time(0);
473 MinidumpParams params; 473 MinidumpParams params;
474 params.process_name = "process"; 474 params.process_name = "process";
475 475
476 FakeSynchronizedMinidumpUploader uploader; 476 FakeSynchronizedMinidumpUploader uploader;
477 SynchronizedMinidumpManagerSimple producer; 477 SynchronizedMinidumpManagerSimple producer;
478 producer.SetDumpInfoToWrite( 478 producer.SetDumpInfoToWrite(
479 make_scoped_ptr(new DumpInfo("dump1", "log1", now, params))); 479 make_scoped_ptr(new DumpInfo("dump1", "log1", now, params)));
480 480
481 const int iters = 3; 481 const int iters = 3;
482 const int max_dumps = SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps; 482 const int max_dumps = SynchronizedMinidumpManager::kRatelimitPeriodMaxDumps;
483 483
484 for (int i = 0; i < iters; ++i) { 484 for (int i = 0; i < iters; ++i) {
485 produce_dumps(producer, max_dumps + 1); 485 produce_dumps(producer, max_dumps + 1);
486 consume_dumps(uploader, max_dumps); 486 consume_dumps(uploader, max_dumps);
487 487
488 // Should fail with too many dumps 488 // Should fail with too many dumps
489 ASSERT_EQ(0, uploader.DoWorkLocked()); 489 ASSERT_EQ(0, uploader.DoWorkLocked());
490 ASSERT_EQ(false, uploader.can_upload_return_val()); 490 ASSERT_FALSE(uploader.can_upload_return_val());
491 491
492 int64 period = SynchronizedMinidumpManager::kRatelimitPeriodSeconds; 492 int64 period = SynchronizedMinidumpManager::kRatelimitPeriodSeconds;
493 493
494 // Half period shouldn't trigger reset 494 // Half period shouldn't trigger reset
495 produce_dumps(producer, 1); 495 produce_dumps(producer, 1);
496 SetRatelimitPeriodStart(metadata_.value(), now - period / 2); 496 SetRatelimitPeriodStart(metadata_.value(), now - period / 2);
497 ASSERT_EQ(0, uploader.DoWorkLocked()); 497 ASSERT_EQ(0, uploader.DoWorkLocked());
498 ASSERT_EQ(false, uploader.can_upload_return_val()); 498 ASSERT_FALSE(uploader.can_upload_return_val());
499 499
500 // Set period starting time to trigger a reset 500 // Set period starting time to trigger a reset
501 SetRatelimitPeriodStart(metadata_.value(), now - period); 501 SetRatelimitPeriodStart(metadata_.value(), now - period);
502 } 502 }
503 503
504 produce_dumps(producer, 1); 504 produce_dumps(producer, 1);
505 consume_dumps(uploader, 1); 505 consume_dumps(uploader, 1);
506 } 506 }
507 507
508 } // namespace chromecast 508 } // namespace chromecast
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698