Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 133673002: Reduce viewport arguments parsing noise in the DevTools console (Closed)

Created:
6 years, 11 months ago by apavlov
Modified:
6 years, 11 months ago
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Reduce viewport arguments parsing noise in the DevTools console The "minimal-ui" argument is ignored, the other parsing errors have been transformed into warnings. R=kenneth.r.christiansen@intel.com, pfeldman@chromium.org BUG=332794 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164872

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M Source/core/html/HTMLMetaElement-in.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 5 chunks +19 lines, -4 lines 0 comments Download
A Source/web/tests/data/viewport/viewport-warnings-7.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
apavlov
6 years, 11 months ago (2014-01-10 11:16:44 UTC) #1
kenneth.r.christiansen
lgtm
6 years, 11 months ago (2014-01-10 11:42:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/133673002/1
6 years, 11 months ago (2014-01-10 11:43:28 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-10 11:55:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/133673002/1
6 years, 11 months ago (2014-01-10 12:05:51 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 13:14:45 UTC) #6
Message was sent while issue was closed.
Change committed as 164872

Powered by Google App Engine
This is Rietveld 408576698