Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2181)

Unified Diff: Source/web/tests/ViewportTest.cpp

Issue 133673002: Reduce viewport arguments parsing noise in the DevTools console (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLMetaElement-in.cpp ('k') | Source/web/tests/data/viewport/viewport-warnings-7.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/ViewportTest.cpp
diff --git a/Source/web/tests/ViewportTest.cpp b/Source/web/tests/ViewportTest.cpp
index 66ead86ebe89af30ae8c2d1bf0d2693ce82ac3b5..35328248d006b7d8ebc664228c5133d931159b27 100644
--- a/Source/web/tests/ViewportTest.cpp
+++ b/Source/web/tests/ViewportTest.cpp
@@ -2982,7 +2982,7 @@ TEST_F(ViewportTest, viewportWarnings2)
PageScaleConstraints constraints = runViewportTest(page, 320, 352);
EXPECT_EQ(1U, webViewClient.messages.size());
- EXPECT_EQ(WebConsoleMessage::LevelError, webViewClient.messages[0].level);
+ EXPECT_EQ(WebConsoleMessage::LevelWarning, webViewClient.messages[0].level);
EXPECT_STREQ("The key \"wwidth\" is not recognized and ignored.", webViewClient.messages[0].text.utf8().c_str());
EXPECT_EQ(980, constraints.layoutSize.width());
@@ -3006,7 +3006,7 @@ TEST_F(ViewportTest, viewportWarnings3)
PageScaleConstraints constraints = runViewportTest(page, 320, 352);
EXPECT_EQ(1U, webViewClient.messages.size());
- EXPECT_EQ(WebConsoleMessage::LevelError, webViewClient.messages[0].level);
+ EXPECT_EQ(WebConsoleMessage::LevelWarning, webViewClient.messages[0].level);
EXPECT_STREQ("The value \"unrecognized-width\" for key \"width\" is invalid, and has been ignored.",
webViewClient.messages[0].text.utf8().c_str());
@@ -3057,7 +3057,7 @@ TEST_F(ViewportTest, viewportWarnings5)
EXPECT_EQ(5U, webViewClient.messages.size());
- EXPECT_EQ(WebConsoleMessage::LevelError, webViewClient.messages[0].level);
+ EXPECT_EQ(WebConsoleMessage::LevelWarning, webViewClient.messages[0].level);
EXPECT_STREQ("The value \"device-width;\" for key \"width\" is invalid, and has been ignored.",
webViewClient.messages[0].text.utf8().c_str());
@@ -3098,7 +3098,7 @@ TEST_F(ViewportTest, viewportWarnings6)
PageScaleConstraints constraints = runViewportTest(page, 320, 352);
EXPECT_EQ(1U, webViewClient.messages.size());
- EXPECT_EQ(WebConsoleMessage::LevelError, webViewClient.messages[0].level);
+ EXPECT_EQ(WebConsoleMessage::LevelWarning, webViewClient.messages[0].level);
EXPECT_STREQ("The value \"\" for key \"width\" is invalid, and has been ignored.",
webViewClient.messages[0].text.utf8().c_str());
@@ -3110,4 +3110,19 @@ TEST_F(ViewportTest, viewportWarnings6)
EXPECT_TRUE(page->viewportDescription().userZoom);
}
+TEST_F(ViewportTest, viewportWarnings7)
+{
+ ConsoleMessageWebViewClient webViewClient;
+
+ registerMockedHttpURLLoad("viewport/viewport-warnings-7.html");
+
+ FrameTestHelpers::WebViewHelper webViewHelper;
+ webViewHelper.initializeAndLoad(m_baseURL + "viewport/viewport-warnings-7.html", true, 0, &webViewClient, setViewportSettings);
+
+ Page* page = webViewHelper.webViewImpl()->page();
+ runViewportTest(page, 320, 352);
+
+ EXPECT_EQ(0U, webViewClient.messages.size());
+}
+
} // namespace
« no previous file with comments | « Source/core/html/HTMLMetaElement-in.cpp ('k') | Source/web/tests/data/viewport/viewport-warnings-7.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698