Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: Source/core/html/HTMLMetaElement-in.cpp

Issue 133673002: Reduce viewport arguments parsing noise in the DevTools console (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/tests/ViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMetaElement-in.cpp
diff --git a/Source/core/html/HTMLMetaElement-in.cpp b/Source/core/html/HTMLMetaElement-in.cpp
index c1715116dfce720ae8f764fff29f4737e072a856..00eb4dc73b691830815b16b12ebd112df2208617 100644
--- a/Source/core/html/HTMLMetaElement-in.cpp
+++ b/Source/core/html/HTMLMetaElement-in.cpp
@@ -333,6 +333,10 @@ void HTMLMetaElement::processViewportKeyValuePair(const String& keyString, const
reportViewportWarning(TargetDensityDpiUnsupported, String(), String());
return;
}
+ CASE("minimal-ui") {
+ // Ignore vendor-specific argument.
+ return;
+ }
}
reportViewportWarning(UnrecognizedViewportArgumentKeyError, keyString, String());
}
@@ -355,11 +359,10 @@ static MessageLevel viewportErrorMessageLevel(ViewportErrorCode errorCode)
switch (errorCode) {
case TruncatedViewportArgumentValueError:
case TargetDensityDpiUnsupported:
- return WarningMessageLevel;
case UnrecognizedViewportArgumentKeyError:
case UnrecognizedViewportArgumentValueError:
case MaximumScaleTooLargeError:
- return ErrorMessageLevel;
+ return WarningMessageLevel;
}
ASSERT_NOT_REACHED();
« no previous file with comments | « no previous file | Source/web/tests/ViewportTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698