build/android/devil/android/device_utils.py - Issue 1335983002: DeviceUtils: Fix SU command for pre-M devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_utils.py

Issue 1335983002: DeviceUtils: Fix SU command for pre-M devices Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/devil/android/device_utils.py

diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py

index 951bae44f7da32e0639993e51de8499054c415bd..d0d5b38e2399338a88215930fd83188da5e36e93 100644

--- a/build/android/devil/android/device_utils.py

+++ b/build/android/devil/android/device_utils.py

@@ -294,7 +294,7 @@ class DeviceUtils(object):

def _Su(self, command):

if self.build_version_sdk >= version_codes.MARSHMALLOW:

return 'su 0 %s' % command

- return 'su -c %s' % command

+ return 'su -c %s' % cmd_helper.SingleQuote(command)

@decorators.WithTimeoutAndRetriesFromInstance()

def EnableRoot(self, timeout=None, retries=None):

« no previous file with comments | « no previous file | build/android/devil/android/device_utils_test.py » ('j') | no next file with comments »