Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1335443002: Landing Recent QUIC changes until 8/26/2015 19:47 UTC. (Closed)

Created:
5 years, 3 months ago by ramant (doing other things)
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 8/26/2015 19:47 UTC. Fix code relying on undocumented SimpleAtoi quirk, which caused rollback of cl/101239633. The quirk was that if an input contained null byte, everything past this byte would be silently ignored; this behavior will soon be removed. relnote: n/a (only affects tests) passes with strings change patched in. Ported this server side change to keep code similar to internal code. Merge internal change: 101605155 https://codereview.chromium.org/1308323012/ relnote: clang_tidy (tidy up). Fixed include order. Merge internal change: 101595102 https://codereview.chromium.org/1321663007/ relnote: Deprecate FLAGS_quic_allow_ip_migration. Merge internal change: 101489487 https://codereview.chromium.org/1334583002/ relnote: Cache-align the encryption buffer in QuicPacketGenerator::SerializeAndSendPacket. The optimized crypto algorithms operate best on aligned memory. This saves about 0.6% wall time and 0.6% CPU time in QUIC. Merge internal change: 101462412 https://codereview.chromium.org/1327743005/ relnote: Close the QUIC connection when a packet is about to be sent out of order instead of attempting to send it. Merge internal change: 101391398 https://codereview.chromium.org/1304833006/ relnote: Deprecate FLAGS_quic_dont_write_when_flow_unblocked. Merge internal change: 101389540 https://codereview.chromium.org/1329693006/ relnote: Don't add burst tokens to QUIC's PacingSender when in recovery. Reduces over-aggressive sending at small CWNDs. Merge internal change: 101384906 https://codereview.chromium.org/1313623006/ R=rch@chromium.org Committed: https://crrev.com/a8fb60cbd034ddf1c45e592e2e85b394d3741739 Cr-Commit-Position: refs/heads/master@{#348191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -64 lines) Patch
M net/quic/congestion_control/cubic_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/hybrid_slow_start_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender_test.cc View 7 chunks +25 lines, -6 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +1 line, -9 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 2 chunks +12 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
ramant (doing other things)
5 years, 3 months ago (2015-09-09 23:57:02 UTC) #1
Ryan Hamilton
lgtm
5 years, 3 months ago (2015-09-10 14:28:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335443002/1
5 years, 3 months ago (2015-09-10 16:56:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 18:18:04 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8fb60cbd034ddf1c45e592e2e85b394d3741739 Cr-Commit-Position: refs/heads/master@{#348191}
5 years, 3 months ago (2015-09-10 18:18:35 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:12:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8fb60cbd034ddf1c45e592e2e85b394d3741739
Cr-Commit-Position: refs/heads/master@{#348191}

Powered by Google App Engine
This is Rietveld 408576698