Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1331053003: Landing Recent QUIC changes until 8/28/2015 18:03 UTC. (Closed)

Created:
5 years, 3 months ago by ramant (doing other things)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0909_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 8/28/2015 18:03 UTC. relnote: Refactor QuicAckFrame::missing_packets to support a change to a more efficient data structure. No functional change. Merge internal change: 101778041 https://codereview.chromium.org/1330973002/ relnote: n/a (changing DLOGs). Tidy up the DLOG messages on receipt of various frame types. I was confused for a while by the connection close message (my test server was *receiving* it, rather than closing the connection itself), hence the change to that message. Other edits bring consistency. Merge internal change: 101773586 https://codereview.chromium.org/1304373010/ relnote: QUIC bugfix (and test) for setting smaller receive window size under flow-control auto-tuning. Behavior gated by finch tag AFCW, which is currently enabled in canary and dev. Prior to this fix, streams established before the crypto handshake, i.e. headers and crypto, would have their flow control window size become out of sync between client and server, when tags to set smaller initial window sizes were used (kIFW*). It is believed this was causing some flow control deadlocks in the auto-tuning trial. This change also corrects an oversight, adding logic so that kIFW* reduce the initial session flow control window size as well. Merge internal change: 101695854 https://codereview.chromium.org/1327903004/ relnote: Add num_connections_ in quic_time_wait_list_manager to record number of connection IDs in time wait list. (No functional change) Merge internal change: 101619602 https://codereview.chromium.org/1310753008/ relnote: Allow individual QUIC writers to limit the maximum packet size. Protected by FLAGS_quic_limit_mtu_by_writer, enabled by default. Since this CL, all QuicConnections are required to have a valid peer address when they are created. FIXED=23280955 Merge internal change: 101617105 https://codereview.chromium.org/1320303009/ R=rch@chromium.org, sergeyu@chromium.org Committed: https://crrev.com/493d90ef42c523aa443191dbe7c6fab35be91abf Cr-Commit-Position: refs/heads/master@{#348555}

Patch Set 1 #

Patch Set 2 : reverted 101790938 #

Patch Set 3 : Fix remoting build failure #

Patch Set 4 : use iterator for begin and end methods of PacketNumberQueue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+788 lines, -296 lines) Patch
M net/quic/quic_chromium_client_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 2 chunks +8 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 16 chunks +80 lines, -31 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 4 chunks +14 lines, -17 lines 0 comments Download
M net/quic/quic_connection_logger_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 31 chunks +146 lines, -33 lines 0 comments Download
M net/quic/quic_default_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_default_packet_writer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_flow_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_framer_test.cc View 12 chunks +22 lines, -40 lines 0 comments Download
M net/quic/quic_packet_writer.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 1 2 3 3 chunks +56 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 2 3 2 chunks +76 lines, -15 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 3 chunks +96 lines, -13 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 4 chunks +13 lines, -16 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_sent_entropy_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_entropy_manager.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_sent_entropy_manager_test.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 20 chunks +21 lines, -38 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +39 lines, -12 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 10 chunks +93 lines, -29 lines 0 comments Download
M net/tools/quic/quic_client_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_default_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_default_packet_writer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_per_connection_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_per_connection_packet_writer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_per_connection_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_per_connection_packet_writer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_packet_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_packet_writer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 2 chunks +7 lines, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 4 chunks +5 lines, -1 line 0 comments Download
M remoting/protocol/quic_channel_factory.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (13 generated)
ramant (doing other things)
5 years, 3 months ago (2015-09-10 17:01:36 UTC) #1
Ryan Hamilton
lgtm
5 years, 3 months ago (2015-09-10 23:19:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331053003/1
5 years, 3 months ago (2015-09-11 01:00:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/96497)
5 years, 3 months ago (2015-09-11 01:26:41 UTC) #6
ramant (doing other things)
Hi Sergey, Could you look at remoting/protocol/quic_channel_factory.cc changes. Added GetMaxPacketSize virtual method of quic_packet_reader. Hi ...
5 years, 3 months ago (2015-09-11 23:03:16 UTC) #8
Sergey Ulanov
lgtm
5 years, 3 months ago (2015-09-11 23:07:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331053003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331053003/60001
5 years, 3 months ago (2015-09-11 23:32:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/96539)
5 years, 3 months ago (2015-09-12 01:04:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331053003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331053003/60001
5 years, 3 months ago (2015-09-12 01:07:45 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/52059) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-12 02:34:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331053003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331053003/60001
5 years, 3 months ago (2015-09-12 02:37:18 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/69007)
5 years, 3 months ago (2015-09-12 08:39:44 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331053003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331053003/60001
5 years, 3 months ago (2015-09-12 14:58:13 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/69072)
5 years, 3 months ago (2015-09-12 21:00:07 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331053003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331053003/60001
5 years, 3 months ago (2015-09-13 23:28:15 UTC) #28
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-14 04:43:22 UTC) #29
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/493d90ef42c523aa443191dbe7c6fab35be91abf Cr-Commit-Position: refs/heads/master@{#348555}
5 years, 3 months ago (2015-09-14 04:47:43 UTC) #30
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:29:07 UTC) #31
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/493d90ef42c523aa443191dbe7c6fab35be91abf
Cr-Commit-Position: refs/heads/master@{#348555}

Powered by Google App Engine
This is Rietveld 408576698