Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334673002: Add warnings and hints to for-in. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -45 lines) Patch
M pkg/compiler/lib/src/common/names.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/helpers/stats.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 9 chunks +60 lines, -18 lines 2 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 4 chunks +11 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 12 chunks +187 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 3 months ago (2015-09-10 10:44:10 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1334673002/diff/1/pkg/compiler/lib/src/typechecker.dart File pkg/compiler/lib/src/typechecker.dart (right): https://codereview.chromium.org/1334673002/diff/1/pkg/compiler/lib/src/typechecker.dart#newcode1820 pkg/compiler/lib/src/typechecker.dart:1820: visitAsyncForIn(AsyncForIn node) { Could you do the same ...
5 years, 3 months ago (2015-09-10 13:07:21 UTC) #3
Johnni Winther
https://codereview.chromium.org/1334673002/diff/1/pkg/compiler/lib/src/typechecker.dart File pkg/compiler/lib/src/typechecker.dart (right): https://codereview.chromium.org/1334673002/diff/1/pkg/compiler/lib/src/typechecker.dart#newcode1820 pkg/compiler/lib/src/typechecker.dart:1820: visitAsyncForIn(AsyncForIn node) { On 2015/09/10 13:07:21, sigurdm wrote: > ...
5 years, 3 months ago (2015-09-11 10:36:41 UTC) #4
Johnni Winther
5 years, 3 months ago (2015-09-11 10:39:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d6553747369e2add3fe5b57cdc761bb2a6d4dab0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698