pkg/compiler/lib/src/helpers/stats.dart - Issue 1334673002: Add warnings and hints to for-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/helpers/stats.dart

Issue 1334673002: Add warnings and hints to for-in. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/helpers/stats.dart

diff --git a/pkg/compiler/lib/src/helpers/stats.dart b/pkg/compiler/lib/src/helpers/stats.dart

index 13897c72c46425d72160ed48b7f3e8b142204ce1..d7f6b5d5f6890959e8939101e5f8beecc3e59114 100644

--- a/pkg/compiler/lib/src/helpers/stats.dart

+++ b/pkg/compiler/lib/src/helpers/stats.dart

@@ -458,7 +458,7 @@ class _StackTraceNode implements Comparable<_StackTraceNode> {

indentation = ''.padLeft(countText.length, ' ');

if (commonPrefix != null) {

int index = 0;

- for (String line in commonPrefix) {

+ for (StackTraceLine line in commonPrefix) {

sb.write(indentation);

if (index > 1) {

sb.write('...\n');