Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: pkg/compiler/lib/src/helpers/stats.dart

Issue 1334673002: Add warnings and hints to for-in. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.helpers; 5 part of dart2js.helpers;
6 6
7 // Helper methods for statistics. 7 // Helper methods for statistics.
8 8
9 /// Current stats collector. Use [enableStatsOutput] to enable recording of 9 /// Current stats collector. Use [enableStatsOutput] to enable recording of
10 /// stats. 10 /// stats.
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 return other.count - count; 451 return other.count - count;
452 } 452 }
453 453
454 void printOn(StringBuffer sb, String indentation) { 454 void printOn(StringBuffer sb, String indentation) {
455 String countText = '$indentation$count '; 455 String countText = '$indentation$count ';
456 sb.write(countText); 456 sb.write(countText);
457 sb.write('\n'); 457 sb.write('\n');
458 indentation = ''.padLeft(countText.length, ' '); 458 indentation = ''.padLeft(countText.length, ' ');
459 if (commonPrefix != null) { 459 if (commonPrefix != null) {
460 int index = 0; 460 int index = 0;
461 for (String line in commonPrefix) { 461 for (StackTraceLine line in commonPrefix) {
462 sb.write(indentation); 462 sb.write(indentation);
463 if (index > 1) { 463 if (index > 1) {
464 sb.write('...\n'); 464 sb.write('...\n');
465 break; 465 break;
466 } 466 }
467 sb.write(line); 467 sb.write(line);
468 sb.write('\n'); 468 sb.write('\n');
469 index++; 469 index++;
470 } 470 }
471 } 471 }
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 /// Returns a new map in which the keys of [map] are sorted using [compare]. 779 /// Returns a new map in which the keys of [map] are sorted using [compare].
780 /// If [compare] is null, the keys must be [Comparable]. 780 /// If [compare] is null, the keys must be [Comparable].
781 Map sortMap(Map map, [int compare(a,b)]) { 781 Map sortMap(Map map, [int compare(a,b)]) {
782 List keys = map.keys.toList(); 782 List keys = map.keys.toList();
783 keys.sort(compare); 783 keys.sort(compare);
784 Map sortedMap = new Map(); 784 Map sortedMap = new Map();
785 keys.forEach((k) => sortedMap[k] = map[k]); 785 keys.forEach((k) => sortedMap[k] = map[k]);
786 return sortedMap; 786 return sortedMap;
787 } 787 }
788 788
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698