Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1334523002: Revert of Port uses of SkLazyPtr to SkOncePtr. (Closed)

Created:
5 years, 3 months ago by mtklein
Modified:
5 years, 3 months ago
Reviewers:
herb_g, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Port uses of SkLazyPtr to SkOncePtr. (patchset #7 id:110001 of https://codereview.chromium.org/1322933005/ ) Reason for revert: Breaks Chrome roll. obj/skia/ext/skia_chrome.skia_memory_dump_provider.o does not have -I include/private on its include path, but transitively includes SkMessageBus.h. Original issue's description: > Port uses of SkLazyPtr to SkOncePtr. > > This gives SkOncePtr a non-trivial destructor that uses std::default_delete > by default. This is overrideable, as seen in SkColorTable. > > SK_DECLARE_STATIC_ONCE_PTR still just leaves its pointers hanging at EOP. > > BUG=skia: > > No public API changes. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/a1254acdb344174e761f5061c820559dab64a74c TBR=herb@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2ac6793efc9b33f6104f9c39810bee5714bdc208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -117 lines) Patch
M include/core/SkColorTable.h View 2 chunks +4 lines, -4 lines 0 comments Download
A include/core/SkLazyPtr.h View 1 chunk +188 lines, -0 lines 0 comments Download
M include/core/SkTypeface.h View 2 chunks +6 lines, -3 lines 0 comments Download
M include/private/SkOncePtr.h View 3 chunks +11 lines, -12 lines 0 comments Download
M src/core/SkBigPicture.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBigPicture.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkColorTable.cpp View 1 chunk +15 lines, -3 lines 0 comments Download
M src/core/SkData.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M src/core/SkFontMgr.cpp View 2 chunks +10 lines, -6 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +9 lines, -4 lines 0 comments Download
M src/core/SkMessageBus.h View 2 chunks +9 lines, -6 lines 0 comments Download
M src/core/SkMiniRecorder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPathRef.cpp View 3 chunks +12 lines, -8 lines 0 comments Download
M src/core/SkTypeface.cpp View 3 chunks +39 lines, -20 lines 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +16 lines, -9 lines 0 comments Download
M src/fonts/SkRemotableFontMgr.cpp View 2 chunks +9 lines, -3 lines 0 comments Download
M src/lazy/SkDiscardableMemoryPool.cpp View 2 chunks +13 lines, -8 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 4 chunks +7 lines, -5 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 5 chunks +19 lines, -7 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 4 chunks +9 lines, -4 lines 0 comments Download
M src/utils/SkEventTracer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A tests/LazyPtrTest.cpp View 1 chunk +70 lines, -0 lines 0 comments Download
M tests/OncePtrTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Port uses of SkLazyPtr to SkOncePtr.
5 years, 3 months ago (2015-09-09 14:10:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334523002/1
5 years, 3 months ago (2015-09-09 14:10:33 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 14:10:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ac6793efc9b33f6104f9c39810bee5714bdc208

Powered by Google App Engine
This is Rietveld 408576698