call onPageFinished when you cancel the ssl error

call onPageFinished when you cancel the ssl error

This fixes the issue introduced by the following code review:
https://codereview.chromium.org/68763012/

BUG=337985
R=benm@chromium.org, sgurun@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247464

[hush (inactive), 2014-01-18 00:24:39]

PTAL

[sgurun-gerrit only, 2014-01-18 00:35:42]

https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java
(right):

https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java:59:
// Need to call onPageFinished when you cancel on the ssl error
I think a less verbose comment is better. Maybe say
// Call onPageFinished when canceling the SSL error.
nit: . after error.

[sgurun-gerrit only, 2014-01-18 00:36:11]

On 2014/01/18 00:35:42, sgurun wrote:
>
https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
> File
>
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java
> (right):
> 
>
https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
>
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java:59:
> // Need to call onPageFinished when you cancel on the ssl error
> I think a less verbose comment is better. Maybe say
> // Call onPageFinished when canceling the SSL error.
> nit: . after error.


Also remove the Change-Id in bug description.

[benm (inactive), 2014-01-20 20:04:59]

https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java
(right):

https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java:59:
// Need to call onPageFinished when you cancel on the ssl error
Maybe worth noting that this is done for backwards compatibility with the
Classic WebView.

On 2014/01/18 00:35:42, sgurun wrote:
> I think a less verbose comment is better. Maybe say
> // Call onPageFinished when canceling the SSL error.
> nit: . after error.

[hush (inactive), 2014-01-24 20:08:15]

please take another look

[hush (inactive), 2014-01-24 21:52:25]

https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
File
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java
(right):

https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java:59:
// Need to call onPageFinished when you cancel on the ssl error
On 2014/01/18 00:35:42, sgurun wrote:
> I think a less verbose comment is better. Maybe say
> // Call onPageFinished when canceling the SSL error.
> nit: . after error.

Done.

https://codereview.chromium.org/133273033/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java:59:
// Need to call onPageFinished when you cancel on the ssl error
On 2014/01/20 20:04:59, benm wrote:
> Maybe worth noting that this is done for backwards compatibility with the
> Classic WebView.
> 
> On 2014/01/18 00:35:42, sgurun wrote:
> > I think a less verbose comment is better. Maybe say
> > // Call onPageFinished when canceling the SSL error.
> > nit: . after error.
> 

Done.

[sgurun-gerrit only, 2014-01-24 22:47:58]

lgtm

[hush (inactive), 2014-01-24 22:50:32]

Ben will be out of office.
Hi Bo, can you take a look? Thanks.

[benm (inactive), 2014-01-24 22:52:01]

lgtm thanks!

But we need an upstream chromium bug to track merging this.

[boliu, 2014-01-25 19:29:59]

Err...cq is not picking this up for some reason (it's not down or overloaded)

https://chromium-status.appspot.com/cq/hush%40chromium.org/133273033/110001

[sgurun-gerrit only, 2014-01-28 00:57:04]

On 2014/01/25 19:29:59, boliu wrote:
> Err...cq is not picking this up for some reason (it's not down or overloaded)
> 
> https://chromium-status.appspot.com/cq/hush%2540chromium.org/133273033/110001

Interesting, I tried committing, and it did not work, either. at least until
now...

[boliu, 2014-01-28 00:59:15]

On 2014/01/28 00:57:04, sgurun wrote:
> On 2014/01/25 19:29:59, boliu wrote:
> > Err...cq is not picking this up for some reason (it's not down or
overloaded)
> > 
> >
https://chromium-status.appspot.com/cq/hush%252540chromium.org/133273033/110001
> 
> Interesting, I tried committing, and it did not work, either. at least until
> now...

So run through the android bots and wait until they are all green, then dcommit
this (Selim or I can do it for you)

[sgurun-gerrit only, 2014-01-28 17:56:21]

Committed patchset #2 manually as r247464 (presubmit successful).