call onPageFinished when you cancel the ssl error

android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview;
 
 import android.net.http.SslCertificate;
 import android.net.http.SslError;
 import android.webkit.ValueCallback;
 
@@ skipping 37 matching lines @@
         final SslCertificate cert = SslUtil.getCertificateFromDerBytes(derBytes);
         if (cert == null) {
             // if the certificate or the client is null, cancel the request
             return false;
         }
         final SslError sslError = SslUtil.sslErrorFromNetErrorCode(certError, cert, url);
         ValueCallback<Boolean> callback = new ValueCallback<Boolean>() {
             @Override
             public void onReceiveValue(Boolean value) {
                 proceedSslError(value.booleanValue(), id);
+                if (!value) {
+                    // Need to call onPageFinished when you cancel on the ssl error

[sgurun-gerrit only, 2014/01/18 00:35:42]

I think a less verbose comment is better. Maybe say
// Call onPageFinished when canceling the SSL error.
nit: . after error.

[benm (inactive), 2014/01/20 20:04:59]

Maybe worth noting that this is done for backwards compatibility with the
Classic WebView.

On 2014/01/18 00:35:42, sgurun wrote:

[hush (inactive), 2014/01/24 21:52:26]

Done.

[hush (inactive), 2014/01/24 21:52:26]

Done.

+                    AwContentsClientBridge.this.mClient.onPageFinished(url);
+                }
             }
         };
         mClient.onReceivedSslError(callback, sslError);
         return true;
     }
 
     private void proceedSslError(boolean proceed, int id) {
         if (mNativeContentsClientBridge == 0) return;
         nativeProceedSslError(mNativeContentsClientBridge, proceed, id);
     }
@@ skipping 40 matching lines @@
     //--------------------------------------------------------------------------------------------
     //  Native methods
     //--------------------------------------------------------------------------------------------
     private native void nativeProceedSslError(long nativeAwContentsClientBridge, boolean proceed,
             int id);
 
     private native void nativeConfirmJsResult(long nativeAwContentsClientBridge, int id,
             String prompt);
     private native void nativeCancelJsResult(long nativeAwContentsClientBridge, int id);
 }