Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133273007: Revert "Moved text decoding to the parser thread" (Closed)

Created:
6 years, 11 months ago by oystein (OOO til 10th of July)
Modified:
6 years, 11 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, kinuko+watch, aandrey+blink_chromium.org, caseq+blink_chromium.org, bemjb+rendering_chromium.org, yurys+blink_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, nessy, loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, Nate Chapin, vcarbune.chromium, philipj_slow, alph+blink_chromium.org, gasubic, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert "Moved text decoding to the parser thread" This reverts 164797 R=abarth@chromium.org,eseidel@chromium.org BUG=329603 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -970 lines) Patch
M Source/core/core.gypi View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.cpp View 4 chunks +19 lines, -11 lines 0 comments Download
M Source/core/dom/Document.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 5 chunks +13 lines, -14 lines 0 comments Download
M Source/core/dom/DocumentEncodingData.h View 1 chunk +9 lines, -21 lines 0 comments Download
D Source/core/dom/DocumentEncodingData.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
M Source/core/dom/DocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/DocumentResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ShaderResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/fetch/TextResourceDecoder.h View 2 chunks +1 line, -2 lines 0 comments Download
A + Source/core/fetch/TextResourceDecoder.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBaseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.h View 6 chunks +8 lines, -11 lines 0 comments Download
M Source/core/html/parser/BackgroundHTMLParser.cpp View 4 chunks +0 lines, -44 lines 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 5 chunks +14 lines, -51 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.h View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.cpp View 3 chunks +89 lines, -9 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.cpp View 2 chunks +0 lines, -90 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.cpp View 2 chunks +10 lines, -11 lines 0 comments Download
M Source/core/html/parser/HTMLViewSourceParser.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/parser/TextDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/TextDocumentParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/html/parser/TextResourceDecoder.h View 1 chunk +0 lines, -106 lines 0 comments Download
D Source/core/html/parser/TextResourceDecoder.cpp View 1 chunk +0 lines, -437 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 5 chunks +22 lines, -32 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/NetworkResourcesData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentWriter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/loader/TextResourceDecoderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
oystein (OOO til 10th of July)
6 years, 11 months ago (2014-01-14 18:54:33 UTC) #1
abarth-chromium
rslgtm
6 years, 11 months ago (2014-01-14 19:03:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/133273007/1
6 years, 11 months ago (2014-01-14 19:08:29 UTC) #3
commit-bot: I haz the power
Change committed as 165102
6 years, 11 months ago (2014-01-15 00:45:28 UTC) #4
oystein (OOO til 10th of July)
6 years, 11 months ago (2014-01-17 18:52:42 UTC) #5
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/141143007/ by oysteine@chromium.org.

The reason for reverting is: High confidence of having identified the cause of
the crash now, will apply that in second changelist..

Powered by Google App Engine
This is Rietveld 408576698