Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: Source/core/html/parser/BackgroundHTMLParser.cpp

Issue 133273007: Revert "Moved text decoding to the parser thread" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/parser/BackgroundHTMLParser.h ('k') | Source/core/html/parser/CSSPreloadScanner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/BackgroundHTMLParser.cpp
diff --git a/Source/core/html/parser/BackgroundHTMLParser.cpp b/Source/core/html/parser/BackgroundHTMLParser.cpp
index 77d11543259836602909d8da77ebeed03c3d073e..b91dafd40b937a88e3e8a56efe946d0f861fe5fa 100644
--- a/Source/core/html/parser/BackgroundHTMLParser.cpp
+++ b/Source/core/html/parser/BackgroundHTMLParser.cpp
@@ -28,7 +28,6 @@
#include "core/html/parser/HTMLDocumentParser.h"
#include "core/html/parser/HTMLParserThread.h"
-#include "core/html/parser/TextResourceDecoder.h"
#include "core/html/parser/XSSAuditor.h"
#include "wtf/MainThread.h"
#include "wtf/text/TextPosition.h"
@@ -77,12 +76,6 @@ static void checkThatXSSInfosAreSafeToSendToAnotherThread(const XSSInfoStream& i
#endif
-void BackgroundHTMLParser::start(PassRefPtr<WeakReference<BackgroundHTMLParser> > reference, PassOwnPtr<Configuration> config)
-{
- new BackgroundHTMLParser(reference, config);
- // Caller must free by calling stop().
-}
-
BackgroundHTMLParser::BackgroundHTMLParser(PassRefPtr<WeakReference<BackgroundHTMLParser> > reference, PassOwnPtr<Configuration> config)
: m_weakFactory(reference, this)
, m_token(adoptPtr(new HTMLToken))
@@ -93,11 +86,6 @@ BackgroundHTMLParser::BackgroundHTMLParser(PassRefPtr<WeakReference<BackgroundHT
, m_pendingTokens(adoptPtr(new CompactHTMLTokenStream))
, m_xssAuditor(config->xssAuditor.release())
, m_preloadScanner(config->preloadScanner.release())
- , m_decoder(config->decoder.release())
-{
-}
-
-BackgroundHTMLParser::~BackgroundHTMLParser()
{
}
@@ -108,38 +96,6 @@ void BackgroundHTMLParser::append(const String& input)
pumpTokenizer();
}
-void BackgroundHTMLParser::appendBytes(PassOwnPtr<Vector<char> > buffer)
-{
- updateDocument(m_decoder->decode(buffer->data(), buffer->size()));
-}
-
-void BackgroundHTMLParser::setDecoder(PassOwnPtr<TextResourceDecoder> decoder)
-{
- m_decoder = decoder;
-}
-
-void BackgroundHTMLParser::flush()
-{
- updateDocument(m_decoder->flush());
-}
-
-void BackgroundHTMLParser::updateDocument(const String& decodedData)
-{
- DocumentEncodingData encodingData(*m_decoder.get());
-
- if (encodingData != m_lastSeenEncodingData) {
- m_lastSeenEncodingData = encodingData;
-
- m_xssAuditor->setEncoding(encodingData.encoding());
- callOnMainThread(bind(&HTMLDocumentParser::didReceiveEncodingDataFromBackgroundParser, m_parser, encodingData));
- }
-
- if (decodedData.isEmpty())
- return;
-
- append(decodedData);
-}
-
void BackgroundHTMLParser::resumeFrom(PassOwnPtr<Checkpoint> checkpoint)
{
m_parser = checkpoint->parser;
« no previous file with comments | « Source/core/html/parser/BackgroundHTMLParser.h ('k') | Source/core/html/parser/CSSPreloadScanner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698