Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1331573002: Revert 201092 "Reland of moved unused CascadeOrder. (patchset #1..." (Closed)

Created:
5 years, 3 months ago by rune
Modified:
5 years, 3 months ago
Reviewers:
kochi
CC:
blink-reviews
Visibility:
Public.

Description

Revert 201092 "Reland of moved unused CascadeOrder. (patchset #1..." > Reland of moved unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1306693007/ ) > > Reason for revert: > I don't think this contributes any of "too many opened files". > (as is commented bay jianli > https://code.google.com/p/chromium/issues/detail?id=524248#c7 ) > > Will revert and reland the original patch. > > > > Original issue's description: > > Revert of Removed unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1291873005/ ) > > > > Reason for revert: > > Speculative revert for causing "Too many opened files in the system". > > > > https://code.google.com/p/chromium/issues/detail?id=523598 > > > > > > Original issue's description: > > > Removed unused CascadeOrder. > > > > > > CascadeOrder is always ignoreCascadeOrder after [1] and can be removed. > > > > > > [1] https://codereview.chromium.org/1298173004 > > > > > > BUG=487125 > > > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019 > > > > TBR=kochi@chromium.org,rune@opera.com > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=487125 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201082 > > TBR=rune@opera.com,jianli@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=487125 > > Review URL: https://codereview.chromium.org/1313713005 TBR=kochi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -30 lines) Patch
M trunk/Source/core/css/ElementRuleCollector.h View 4 chunks +11 lines, -6 lines 0 comments Download
M trunk/Source/core/css/ElementRuleCollector.cpp View 7 chunks +15 lines, -15 lines 0 comments Download
M trunk/Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/Source/core/css/resolver/ScopedStyleResolver.cpp View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rune
5 years, 3 months ago (2015-09-07 11:44:17 UTC) #1
rune
Committed patchset #1 (id:1) manually as r201871.
5 years, 3 months ago (2015-09-07 11:44:27 UTC) #2
kochi
5 years, 3 months ago (2015-09-07 12:58:03 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698