Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1306693007: Revert of Removed unused CascadeOrder. (Closed)

Created:
5 years, 4 months ago by jianli
Modified:
5 years, 4 months ago
Reviewers:
kochi, rune
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@shadow-cascade-order-20150817
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Removed unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1291873005/ ) Reason for revert: Speculative revert for causing "Too many opened files in the system". https://code.google.com/p/chromium/issues/detail?id=523598 Original issue's description: > Removed unused CascadeOrder. > > CascadeOrder is always ignoreCascadeOrder after [1] and can be removed. > > [1] https://codereview.chromium.org/1298173004 > > BUG=487125 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019 TBR=kochi@chromium.org,rune@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487125 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -33 lines) Patch
M Source/core/css/ElementRuleCollector.h View 3 chunks +11 lines, -6 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 7 chunks +18 lines, -18 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jianli
Created Revert of Removed unused CascadeOrder.
5 years, 4 months ago (2015-08-25 00:35:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306693007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306693007/1
5 years, 4 months ago (2015-08-25 00:36:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201082
5 years, 4 months ago (2015-08-25 00:36:29 UTC) #3
kochi
5 years, 4 months ago (2015-08-25 02:46:43 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1313713005/ by kochi@chromium.org.

The reason for reverting is: I don't think this contributes any of "too many
opened files".
(as is commented bay jianli
https://code.google.com/p/chromium/issues/detail?id=524248#c7 )

Will revert and reland the original patch.

.

Powered by Google App Engine
This is Rietveld 408576698