Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: trunk/Source/core/css/ElementRuleCollector.h

Issue 1331573002: Revert 201092 "Reland of moved unused CascadeOrder. (patchset #1..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/Source/core/css/ElementRuleCollector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/core/css/ElementRuleCollector.h
===================================================================
--- trunk/Source/core/css/ElementRuleCollector.h (revision 201870)
+++ trunk/Source/core/css/ElementRuleCollector.h (working copy)
@@ -39,10 +39,14 @@
class SelectorFilter;
class StaticCSSRuleList;
+typedef unsigned CascadeOrder;
+
+const CascadeOrder ignoreCascadeOrder = 0;
+
class MatchedRule {
ALLOW_ONLY_INLINE_ALLOCATION();
public:
- MatchedRule(const RuleData* ruleData, unsigned specificity, unsigned styleSheetIndex, const CSSStyleSheet* parentStyleSheet)
+ MatchedRule(const RuleData* ruleData, unsigned specificity, CascadeOrder cascadeOrder, unsigned styleSheetIndex, const CSSStyleSheet* parentStyleSheet)
: m_ruleData(ruleData)
, m_specificity(specificity)
, m_parentStyleSheet(parentStyleSheet)
@@ -49,7 +53,8 @@
{
ASSERT(m_ruleData);
static const unsigned BitsForPositionInRuleData = 18;
- m_position = ((uint64_t)styleSheetIndex << BitsForPositionInRuleData) + m_ruleData->position();
+ static const unsigned BitsForStyleSheetIndex = 32;
+ m_position = ((uint64_t)cascadeOrder << (BitsForStyleSheetIndex + BitsForPositionInRuleData)) + ((uint64_t)styleSheetIndex << BitsForPositionInRuleData)+ m_ruleData->position();
}
const RuleData* ruleData() const { return m_ruleData; }
@@ -117,8 +122,8 @@
PassRefPtrWillBeRawPtr<StyleRuleList> matchedStyleRuleList();
PassRefPtrWillBeRawPtr<CSSRuleList> matchedCSSRuleList();
- void collectMatchingRules(const MatchRequest&, bool matchingTreeBoundaryRules = false);
- void collectMatchingShadowHostRules(const MatchRequest&, bool matchingTreeBoundaryRules = false);
+ void collectMatchingRules(const MatchRequest&, CascadeOrder = ignoreCascadeOrder, bool matchingTreeBoundaryRules = false);
+ void collectMatchingShadowHostRules(const MatchRequest&, CascadeOrder = ignoreCascadeOrder, bool matchingTreeBoundaryRules = false);
void sortAndTransferMatchedRules();
void clearMatchedRules();
void addElementStyleProperties(const StylePropertySet*, bool isCacheable = true);
@@ -127,9 +132,9 @@
private:
template<typename RuleDataListType>
- void collectMatchingRulesForList(const RuleDataListType*, const MatchRequest&);
+ void collectMatchingRulesForList(const RuleDataListType*, CascadeOrder, const MatchRequest&);
- void didMatchRule(const RuleData&, const SelectorChecker::MatchResult&, const MatchRequest&);
+ void didMatchRule(const RuleData&, const SelectorChecker::MatchResult&, CascadeOrder, const MatchRequest&);
template<class CSSRuleCollection>
CSSRule* findStyleRule(CSSRuleCollection*, StyleRule*);
« no previous file with comments | « no previous file | trunk/Source/core/css/ElementRuleCollector.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698