Issue 13315002: Add in gesture for immersive mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13315002: Add in gesture for immersive mode (Closed)

Created:
7 years, 8 months ago by rharrison

Modified:
7 years, 8 months ago

Reviewers:
pkotwicz, sadrul

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
https://codereview.chromium.org/12529026/

Visibility:
Public.

More Reviews

Description

Add in gesture for immersive mode Adds in a swipe in from the top of the screen to the EdgeGestureHandler. This gestures causes the tabstrip to reveal in the same fashion that moving the mouse to the top of the screen in immersive mode. Currently the tab strip does not reveal by being sticky to the finger like the shelf swipe in. Implementing stickiness will require a significant effort and it is not clear if it is needed yet. There is also an issue with touches outside the tab strip not hidding the shelf, which is left to be resolved in another CL. BUG=chromium:164165 TEST=Entered immersive mode and swiped in from the top of the screen, which caused the tab strip to animate in.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -15 lines)			Patch
M	ash/root_window_controller.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/root_window_controller.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	ash/wm/gestures/edge_gesture_handler.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	ash/wm/gestures/edge_gesture_handler.cc	View	1 2	7 chunks	+44 lines, -14 lines	0 comments	Download
M	ash/wm/window_properties.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ash/wm/window_properties.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc	View	1 2	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Issue 13315002: Add in gesture for immersive mode (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixing so the branch CL this is based off isn't included #

Patch Set 3 : Rebasing #

Messages