Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133133006: Update Event classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update Event classes to use OVERRIDE / FINAL when needed Update Event classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -78 lines) Patch
M Source/core/events/AutocompleteErrorEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/BeforeLoadEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/BeforeTextInsertedEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/BeforeUnloadEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ClipboardEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/CompositionEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/CustomEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/DOMWindowEventQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ErrorEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/FocusEvent.h View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/events/GenericEventQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/GestureEvent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/HashChangeEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/KeyboardEvent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/MessageEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/MouseEvent.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/events/MouseRelatedEvent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/MutationEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/OverflowEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/PageTransitionEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/PopStateEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/ProgressEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ResourceProgressEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/SecurityPolicyViolationEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/TextEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/TouchEvent.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/TransitionEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/UIEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/WebKitAnimationEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/WheelEvent.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 11 months ago (2014-01-10 18:01:11 UTC) #1
eseidel
lgtm
6 years, 11 months ago (2014-01-10 18:14:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/133133006/1
6 years, 11 months ago (2014-01-10 18:14:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/133133006/1
6 years, 11 months ago (2014-01-10 18:30:19 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 19:25:38 UTC) #5
Message was sent while issue was closed. 
Change committed as 164893

Powered by Google App Engine
This is Rietveld 408576698