Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: Source/core/events/ResourceProgressEvent.h

Issue 133133006: Update Event classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/events/ProgressEvent.h ('k') | Source/core/events/SecurityPolicyViolationEvent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 24 matching lines...) Expand all
35 35
36 namespace WebCore { 36 namespace WebCore {
37 37
38 // ResourceProgressEvent is a non-standard class that is simply a ProgressEvent 38 // ResourceProgressEvent is a non-standard class that is simply a ProgressEvent
39 // with an additional read-only "url" property containing a string URL. This is 39 // with an additional read-only "url" property containing a string URL. This is
40 // used by the Chromium NaCl integration to indicate to which resource the 40 // used by the Chromium NaCl integration to indicate to which resource the
41 // event applies. This is useful because the NaCl integration will download 41 // event applies. This is useful because the NaCl integration will download
42 // (and translate in the case of PNaCl) multiple binary files. It is not 42 // (and translate in the case of PNaCl) multiple binary files. It is not
43 // constructable by web content at all, and so does not provide the usual 43 // constructable by web content at all, and so does not provide the usual
44 // EventInit pattern for Event construction. 44 // EventInit pattern for Event construction.
45 class ResourceProgressEvent : public ProgressEvent { 45 class ResourceProgressEvent FINAL : public ProgressEvent {
46 public: 46 public:
47 static PassRefPtr<ResourceProgressEvent> create() 47 static PassRefPtr<ResourceProgressEvent> create()
48 { 48 {
49 return adoptRef(new ResourceProgressEvent); 49 return adoptRef(new ResourceProgressEvent);
50 } 50 }
51 static PassRefPtr<ResourceProgressEvent> create(const AtomicString& type, bo ol lengthComputable, unsigned long long loaded, unsigned long long total, const String& url) 51 static PassRefPtr<ResourceProgressEvent> create(const AtomicString& type, bo ol lengthComputable, unsigned long long loaded, unsigned long long total, const String& url)
52 { 52 {
53 return adoptRef(new ResourceProgressEvent(type, lengthComputable, loaded , total, url)); 53 return adoptRef(new ResourceProgressEvent(type, lengthComputable, loaded , total, url));
54 } 54 }
55 55
56 const String& url() const; 56 const String& url() const;
57 57
58 virtual const AtomicString& interfaceName() const; 58 virtual const AtomicString& interfaceName() const OVERRIDE;
59 59
60 protected: 60 protected:
61 ResourceProgressEvent(); 61 ResourceProgressEvent();
62 ResourceProgressEvent(const AtomicString& type, bool lengthComputable, unsig ned long long loaded, unsigned long long total, const String& url); 62 ResourceProgressEvent(const AtomicString& type, bool lengthComputable, unsig ned long long loaded, unsigned long long total, const String& url);
63 63
64 private: 64 private:
65 String m_url; 65 String m_url;
66 }; 66 };
67 67
68 } // namespace WebCore 68 } // namespace WebCore
69 69
70 #endif // ResourceProgressEvent_h 70 #endif // ResourceProgressEvent_h
OLDNEW
« no previous file with comments | « Source/core/events/ProgressEvent.h ('k') | Source/core/events/SecurityPolicyViolationEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698