Eliminate BaseSessionServiceDelegateImpl

Eliminate BaseSessionServiceDelegateImpl

PersistentTabRestoreService::Delegate is slated for componentization. However,
it inherits from BaseSessionServiceDelegateImpl, which contains //chrome-level
functionality.

This CL eliminates BaseSessionServiceDelegateImpl, instead having
PersistentTabRestoreService::Delegate and SessionService each inherit directly
from BaseSessionServiceDelegate. The one non-trivial method in
BaseSessionServiceDelegateImpl (ShouldTrackEntry()) is pulled out into a
standalone //chrome-level util function to avoid code duplication between
ChromeTabRestoreServiceClient and SessionService.

BUG=530165
Committed: https://crrev.com/6d34c3450bc604a9a3f752839442b9d5f87a2a4b
Cr-Commit-Position: refs/heads/master@{#348363}

[blundell, 2015-09-10 16:17:25]

blundell@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-09-10 18:03:51]

LGTM with a better name

https://codereview.chromium.org/1331173002/diff/1/chrome/browser/sessions/ses...
File chrome/browser/sessions/session_common_utils.h (right):

https://codereview.chromium.org/1331173002/diff/1/chrome/browser/sessions/ses...
chrome/browser/sessions/session_common_utils.h:13: bool ShouldTrackEntry(const
GURL& url);
This function name, and description, are a bit cryptic when viewed in isolation.
Maybe ShouldRestoreUrl?

[blundell, 2015-09-11 08:07:53]

https://codereview.chromium.org/1331173002/diff/1/chrome/browser/sessions/ses...
File chrome/browser/sessions/session_common_utils.h (right):

https://codereview.chromium.org/1331173002/diff/1/chrome/browser/sessions/ses...
chrome/browser/sessions/session_common_utils.h:13: bool ShouldTrackEntry(const
GURL& url);
On 2015/09/10 18:03:51, sky wrote:
> This function name, and description, are a bit cryptic when viewed in
isolation.
> Maybe ShouldRestoreUrl?

Thanks for pointing this out. I changed to ShouldTrackURLForRestore(), including
changing the client method: I think it's more clear even in the context of the
client.

[blundell, 2015-09-11 08:07:57]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-09-11 08:07:57]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1331173002/#ps20001
(title: "Response to reviewv")

[commit-bot: I haz the power, 2015-09-11 08:08:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1331173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1331173002/20001

[commit-bot: I haz the power, 2015-09-11 09:09:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-11 09:10:23]

Patchset 2 (id:??) landed as
https://crrev.com/6d34c3450bc604a9a3f752839442b9d5f87a2a4b
Cr-Commit-Position: refs/heads/master@{#348363}

[commit-bot: I haz the power, 2015-09-23 12:20:40]

Patchset 2 (id:??) landed as
https://crrev.com/6d34c3450bc604a9a3f752839442b9d5f87a2a4b
Cr-Commit-Position: refs/heads/master@{#348363}