chrome/browser/sessions/session_common_utils.h - Issue 1331173002: Eliminate BaseSessionServiceDelegateImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sessions/session_common_utils.h

Issue 1331173002: Eliminate BaseSessionServiceDelegateImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@persistent_tab_restore_service_client

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_

	6 #define CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_

	7

	8 class GURL;

	9

	10 // Returns whether sessions code should track an entry in the context of

	11 // //chrome. In particular, blacklists chrome://quit and chrome://restart to

	12 // avoid quit or restart loops.

	13 bool ShouldTrackEntry(const GURL& url);
	sky 2015/09/10 18:03:51 This function name, and description, are a bit cry This function name, and description, are a bit cryptic when viewed in isolation. Maybe ShouldRestoreUrl? blundell 2015/09/11 08:07:53 Thanks for pointing this out. I changed to ShouldT Show quoted text On 2015/09/10 18:03:51, sky wrote: > This function name, and description, are a bit cryptic when viewed in isolation. > Maybe ShouldRestoreUrl? Thanks for pointing this out. I changed to ShouldTrackURLForRestore(), including changing the client method: I think it's more clear even in the context of the client.
	14

	15 #endif // CHROME_BROWSER_SESSIONS_SESSION_COMMON_UTILS_H_

OLD	NEW

« no previous file with comments | « chrome/browser/sessions/persistent_tab_restore_service.cc ('k') | chrome/browser/sessions/session_common_utils.cc » ('j') | no next file with comments »