Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: components/sessions/base_session_service_delegate.h

Issue 1331173002: Eliminate BaseSessionServiceDelegateImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@persistent_tab_restore_service_client
Patch Set: Response to reviewv Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/sessions/core/tab_restore_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sessions/base_session_service_delegate.h
diff --git a/components/sessions/base_session_service_delegate.h b/components/sessions/base_session_service_delegate.h
index 45e0020cbc84bb1ac159605c1221e28ea09e6ee9..914ba1b04a4801f6d78e95b586eacde84ff0255f 100644
--- a/components/sessions/base_session_service_delegate.h
+++ b/components/sessions/base_session_service_delegate.h
@@ -11,8 +11,6 @@ namespace base {
class SequencedWorkerPool;
}
-class GURL;
-
namespace sessions {
// The BaseSessionServiceDelegate decouples the BaseSessionService from
@@ -25,18 +23,15 @@ class BaseSessionServiceDelegate {
// long as the system is not shutting down.
virtual base::SequencedWorkerPool* GetBlockingPool() = 0;
- // Tests if a given URL should be tracked.
- virtual bool ShouldTrackEntry(const GURL& url) = 0;
-
// Returns true if save operations can be performed as a delayed task - which
// is usually only used by unit tests.
virtual bool ShouldUseDelayedSave() = 0;
// Called when commands are about to be written to disc.
- virtual void OnWillSaveCommands() = 0;
+ virtual void OnWillSaveCommands() {}
// Called when commands were saved to disc.
- virtual void OnSavedCommands() = 0;
+ virtual void OnSavedCommands() {}
protected:
virtual ~BaseSessionServiceDelegate() {}
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/sessions/core/tab_restore_service_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698