Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1331113002: Popular sites on the NTP: Add Finch params for country and version (Closed)

Created:
5 years, 3 months ago by Marc Treib
Modified:
5 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, knn, May
Base URL:
https://chromium.googlesource.com/chromium/src.git@dont_leak_files
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Popular sites on the NTP: Add Finch params for country and version so that we can specify them separately (e.g. explicitly set a version, but use the client-side country detection). BUG=516618 Committed: https://crrev.com/b28d6505698940eb2886540c8e877643c7c8d801 Cr-Commit-Position: refs/heads/master@{#350151}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -15 lines) Patch
M chrome/browser/android/most_visited_sites.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/android/popular_sites.h View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/android/popular_sites.cc View 5 chunks +30 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Marc Treib
5 years, 3 months ago (2015-09-10 13:17:34 UTC) #2
Bernhard Bauer
lgtm
5 years, 3 months ago (2015-09-10 13:35:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331113002/40001
5 years, 3 months ago (2015-09-22 13:45:31 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-22 14:28:57 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 14:30:33 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b28d6505698940eb2886540c8e877643c7c8d801
Cr-Commit-Position: refs/heads/master@{#350151}

Powered by Google App Engine
This is Rietveld 408576698