Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/android/popular_sites.h

Issue 1331113002: Popular sites on the NTP: Add Finch params for country and version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dont_leak_files
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/most_visited_sites.cc ('k') | chrome/browser/android/popular_sites.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/popular_sites.h
diff --git a/chrome/browser/android/popular_sites.h b/chrome/browser/android/popular_sites.h
index be5687978315c85dc2bfe8ae5bdf3a7b30a0b52a..635d3732220a391d2c780880a9f058bd398c6e52 100644
--- a/chrome/browser/android/popular_sites.h
+++ b/chrome/browser/android/popular_sites.h
@@ -46,9 +46,16 @@ class PopularSites {
using FinishedCallback = base::Callback<void(bool /* success */)>;
// Usually, the name of the file that's downloaded is based on the user's
- // locale. |filename|, if non-empty, will override that default name.
+ // locale. |override_country| (if non-empty) is used to override the
+ // auto-detected country. |override_version|, if non-empty, will
+ // override the baked-in default version.
+ // |override_filename|, if non-empty, will override the full filename
+ // (so |override_country| and |override_version| are ignored in this case).
+ // TODO(treib): Get rid of |override_filename|.
PopularSites(Profile* profile,
- const std::string& filename,
+ const std::string& override_country,
+ const std::string& override_version,
+ const std::string& override_filename,
const FinishedCallback& callback);
~PopularSites();
« no previous file with comments | « chrome/browser/android/most_visited_sites.cc ('k') | chrome/browser/android/popular_sites.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698