Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1306043005: Popular sites on the NTP: store downloaded file at a fixed path (Closed)

Created:
5 years, 3 months ago by Marc Treib
Modified:
5 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@redownload
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Popular sites on the NTP: store downloaded file at a fixed path Before, we'd leak a previously-downloaded file whenever the filename changed. BUG=516618 Committed: https://crrev.com/76e005e8ceb507becf8c2ae737a0d2ae5e274223 Cr-Commit-Position: refs/heads/master@{#350147}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M chrome/browser/android/most_visited_sites.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/popular_sites.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/popular_sites.cc View 4 chunks +16 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Marc Treib
https://codereview.chromium.org/1306043005/diff/1/chrome/browser/android/popular_sites.h File chrome/browser/android/popular_sites.h (left): https://codereview.chromium.org/1306043005/diff/1/chrome/browser/android/popular_sites.h#oldcode50 chrome/browser/android/popular_sites.h:50: net::URLRequestContextGetter* request_context, Unrelated: There's no need to pass this ...
5 years, 3 months ago (2015-09-09 16:24:01 UTC) #2
Bernhard Bauer
lgtm
5 years, 3 months ago (2015-09-09 16:26:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306043005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306043005/40001
5 years, 3 months ago (2015-09-22 12:42:00 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-22 13:40:43 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 13:41:25 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/76e005e8ceb507becf8c2ae737a0d2ae5e274223
Cr-Commit-Position: refs/heads/master@{#350147}

Powered by Google App Engine
This is Rietveld 408576698