Issue 1330113002: Rename WebSourceBuffer::abort into WebSourceBuffer::resetParserState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1330113002: Rename WebSourceBuffer::abort into WebSourceBuffer::resetParserState (Closed)

Created:
5 years, 3 months ago by servolk

Modified:
5 years, 3 months ago

Reviewers:

CC:
blink-reviews, mlamouri+watch-blink_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink, philipj_slow, eric.carlson_apple.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename WebSourceBuffer::abort into WebSourceBuffer::resetParserState As discussed in https://codereview.chromium.org/1013923002/, we could rename WebSourceBuffer::abort into WebSourceBuffer::resetParserState to avoid confusion that it's not the same thing as SourceBuffer::abort, and just one of the steps of the MSE abort algorithm. BUG=529497

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -16 lines)			Patch
A	LayoutTests/fast/dom/nodesFromRect/nodesFromRect-child-frame-scrolled-content.html	View	1 chunk	+68 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/nodesFromRect/nodesFromRect-child-frame-scrolled-content-expected.txt	View	1 chunk	+7 lines, -4 lines	0 comments	Download
A	LayoutTests/fast/dom/nodesFromRect/resources/child-frame-scrolled.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	Source/core/layout/LayoutPart.cpp	View	1 chunk	+15 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/ui/toolbar.css	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/modules/mediasource/SourceBuffer.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/web/WebRemoteFrameImpl.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	public/platform/WebSourceBuffer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	public/web/WebRemoteFrameClient.h	View	1 chunk	+1 line, -1 line	0 comments	Download