Add a FOUC painting test.

Add a FOUC painting test.

This expands the Sim(ulation) testing framework to support a very rudimentary
compositor that can run a simple BeginMainFrame which runs the WebView's
beginFrame() and layout() steps followed by a simplified paint step which paints
the main layer of every composited layer mapping. This is a very rough
approximation of what the real compositor would do, but is enough to test the
code for avoiding FOUC in DeprecatedPaintLayerPainter's shouldSuppressPaintingLayer
and BlockPainter::paintContents. It's also enough to test the paint invalidation
logic in Document::styleResolverChanged for when we painted by skipping painting
the actual content because of the previously mentioned FOUC avoidance logic.

I also went and added a bunch of comments to the Sim* classes to explain what
they do and how to use the testing framework. A future patch may add a README
so we can use this framework to write future pipeline tests.

This was originally committed as:
https://src.chromium.org/viewvc/blink?view=rev&revision=201944

and reverted because the red background fill in debug builds makes the number
of draw commands vary from Debug to Release. This new patch introduces a
SimCanvas that collects the drawing commands and also disables the red debug
fill. This lets the test use stronger assertions and also means it works in
both Debug and Release builds.

BUG=521692
Committed: https://crrev.com/c999715896955a67460b3a543a76f4453dfe4012
git-svn-id: svn://svn.chromium.org/blink/trunk@202099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[esprehn, 2015-09-05 06:36:10]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-05 06:36:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/20001

[commit-bot: I haz the power, 2015-09-05 07:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-05 07:43:38]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[esprehn, 2015-09-05 20:56:43]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-05 20:56:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/40001

[esprehn, 2015-09-05 21:54:08]

esprehn@chromium.org changed reviewers:
+ dglazkov@chromium.org, pdr@chromium.org

[esprehn, 2015-09-05 21:54:15]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-05 21:54:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/60001

[esprehn, 2015-09-05 21:56:16]

This depends on https://codereview.chromium.org/1309243006 so it won't hit the
RELEASE_ASSERT_NOT_REACHED() but I removed the conflicting code in FrameView so
this patch can pass the bots for now. Once that lands I'll revert the changes in
FrameView::contentRectangleForPaintInvalidation.

[commit-bot: I haz the power, 2015-09-05 23:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-05 23:05:24]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2015-09-06 01:20:15]

holy crap!

[jbroman, 2015-09-06 17:00:51]

(Not a review, just a note on one comment.)

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
File Source/web/tests/sim/SimDisplayItemList.cpp (right):

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
Source/web/tests/sim/SimDisplayItemList.cpp:20: // There's not much we can tell
about a picture, but we can tell if it
It's possible to play a picture back to a mock SkCanvas to figure out what was
drawn.

[esprehn, 2015-09-06 20:27:58]

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
File Source/web/tests/sim/SimDisplayItemList.cpp (right):

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
Source/web/tests/sim/SimDisplayItemList.cpp:20: // There's not much we can tell
about a picture, but we can tell if it
On 2015/09/06 at 17:00:51, jbroman wrote:
> It's possible to play a picture back to a mock SkCanvas to figure out what was
drawn.

Using gtest mocks? The SkCanvas isn't virtual. Do you have an example?

[esprehn, 2015-09-06 21:17:56]

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
File Source/web/tests/sim/SimDisplayItemList.cpp (right):

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
Source/web/tests/sim/SimDisplayItemList.cpp:20: // There's not much we can tell
about a picture, but we can tell if it
On 2015/09/06 at 20:27:58, esprehn wrote:
> On 2015/09/06 at 17:00:51, jbroman wrote:
> > It's possible to play a picture back to a mock SkCanvas to figure out what
was drawn.
> 
> Using gtest mocks? The SkCanvas isn't virtual. Do you have an example?

Oh I see all the onDraw* virtual methods that the non virtual ones call. I'll
look into that for future tests. Thanks!

[jbroman, 2015-09-07 00:52:37]

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
File Source/web/tests/sim/SimDisplayItemList.cpp (right):

https://codereview.chromium.org/1329553004/diff/60001/Source/web/tests/sim/Si...
Source/web/tests/sim/SimDisplayItemList.cpp:20: // There's not much we can tell
about a picture, but we can tell if it
On 2015/09/06 at 21:17:56, esprehn wrote:
> On 2015/09/06 at 20:27:58, esprehn wrote:
> > On 2015/09/06 at 17:00:51, jbroman wrote:
> > > It's possible to play a picture back to a mock SkCanvas to figure out what
was drawn.
> > 
> > Using gtest mocks? The SkCanvas isn't virtual. Do you have an example?
> 
> Oh I see all the onDraw* virtual methods that the non virtual ones call. I'll
look into that for future tests. Thanks!

Yeah. Here's a simple example of this in a test (the Slimming Paint path uses
SkPicture::playback with the mock canvas).
https://chromium.googlesource.com/chromium/blink/+/98a45304/Source/web/PageOv...

[dglazkov, 2015-09-08 17:54:05]

https://codereview.chromium.org/1329553004/diff/60001/Source/core/frame/Frame...
File Source/core/frame/FrameView.h (right):

https://codereview.chromium.org/1329553004/diff/60001/Source/core/frame/Frame...
Source/core/frame/FrameView.h:291: static void
setInitialTracksPaintInvalidationsForUnitTestsOnly(bool);
The typical prefix we use is ForTesting.

https://codereview.chromium.org/1329553004/diff/60001/Source/core/layout/comp...
File Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
(right):

https://codereview.chromium.org/1329553004/diff/60001/Source/core/layout/comp...
Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp:2028:
// fprintf(stderr, "SetContentsNeedsDisplayInRectFunctor\n");
Remove maybe?

[esprehn, 2015-09-08 20:34:13]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[esprehn, 2015-09-08 20:34:27]

On 2015/09/08 at 17:54:05, dglazkov wrote:
>
https://codereview.chromium.org/1329553004/diff/60001/Source/core/frame/Frame...
> File Source/core/frame/FrameView.h (right):
> 
>
https://codereview.chromium.org/1329553004/diff/60001/Source/core/frame/Frame...
> Source/core/frame/FrameView.h:291: static void
setInitialTracksPaintInvalidationsForUnitTestsOnly(bool);
> The typical prefix we use is ForTesting.
>

Done.
 
>
https://codereview.chromium.org/1329553004/diff/60001/Source/core/layout/comp...
> File Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
(right):
> 
>
https://codereview.chromium.org/1329553004/diff/60001/Source/core/layout/comp...
> Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp:2028:
// fprintf(stderr, "SetContentsNeedsDisplayInRectFunctor\n");
> Remove maybe?

Done.

[commit-bot: I haz the power, 2015-09-08 20:34:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/80001

[dglazkov, 2015-09-08 21:42:48]

lgtm

[commit-bot: I haz the power, 2015-09-08 22:00:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 22:00:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[esprehn, 2015-09-08 23:24:37]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2015-09-08 23:24:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dglazkov@chromium.org
Link to the patchset: https://codereview.chromium.org/1329553004/#ps100001
(title: "Sync.")

[commit-bot: I haz the power, 2015-09-08 23:24:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/100001

[commit-bot: I haz the power, 2015-09-09 00:54:49]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201944

[Mike West, 2015-09-09 08:25:17]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1316673009/ by mkwst@chromium.org.

The reason for reverting is: This patch is failing on debug bots, all platforms.
For example:

*
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg...

*
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28d....

[esprehn, 2015-09-10 07:30:54]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-10 07:31:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/120001

[commit-bot: I haz the power, 2015-09-10 07:47:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-10 07:47:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[esprehn, 2015-09-10 09:00:32]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-10 09:00:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/140001

[commit-bot: I haz the power, 2015-09-10 09:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-10 09:38:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[esprehn, 2015-09-10 23:05:39]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-10 23:05:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/160001

[commit-bot: I haz the power, 2015-09-10 23:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-10 23:31:45]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[esprehn, 2015-09-11 00:51:22]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-11 00:51:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/180001

[esprehn, 2015-09-11 01:17:45]

Okay I fixed the bug that got this reverted, the test also contains actual paint
command assertions now so it's even more robust. This should let us write even
fancier tests in the future.

[dglazkov, 2015-09-11 01:52:39]

On 2015/09/11 at 01:17:45, esprehn wrote:
> Okay I fixed the bug that got this reverted, the test also contains actual
paint command assertions now so it's even more robust. This should let us write
even fancier tests in the future.

Even more LGTM.

[esprehn, 2015-09-11 02:16:52]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2015-09-11 02:16:56]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2015-09-11 02:17:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329553004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329553004/180001

[pdr., 2015-09-11 03:27:28]

On 2015/09/11 at 02:17:00, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1329553004/180001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1329553004/180001

Woohoo! LGTM

I'd like move the debug red fill to the compositor since it frequently causes
issues like this :/

[commit-bot: I haz the power, 2015-09-11 03:31:43]

Committed patchset #10 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202099

[commit-bot: I haz the power, 2015-09-23 12:18:25]

Patchset 10 (id:??) landed as
https://crrev.com/c999715896955a67460b3a543a76f4453dfe4012