Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1309243006: Remove old repaint rect tracking from FrameView. (Closed)

Created:
5 years, 3 months ago by esprehn
Modified:
5 years, 3 months ago
Reviewers:
pdr., dglazkov, enne (OOO)
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rjwright, shans, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove old repaint rect tracking from FrameView. This code only worked when we weren't using FCM mode, but now we always do for tests. We also always run tests with asserts turned on, even for release builds so this code clearly is never used since it contains a RELEASE_ASSERT_NOT_REACHED(). Lets remove it! I also removed the old baselines from tests that used this. These tests must all be disabled on the platforms where these baselines would have been used since we no longer were capable of producing this output without crashing on the ASSERT_NOT_REACHED(). BUG=368518, 521692 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -415 lines) Patch
D LayoutTests/platform/android/fast/repaint/delete-into-nested-block-expected.txt View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-after-remove-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-overflow-scroll-2-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/selection-gap-overflow-scroll-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/shift-relative-positioned-container-with-image-addition-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/video-mute-repaint-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/deep-dynamic-updates-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/js-update-gradient-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/js-update-pattern-child-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/js-update-pattern-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/js-update-stop-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/js-update-stop-linked-gradient-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/repaint-moving-svg-and-div-expected.txt View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/platform/android/svg/custom/use-disappears-after-style-update-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/android/svg/filters/feImage-target-reappend-to-document-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/android/svg/repaint/image-animation-with-zoom-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/android/virtual/spv2/fast/repaint/delete-into-nested-block-expected.txt View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/svg/overflow/overflow-visible-repaint-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/frame/FrameView.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 3 chunks +0 lines, -22 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309243006/1
5 years, 3 months ago (2015-09-05 02:07:47 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-05 03:24:29 UTC) #4
esprehn
Ping
5 years, 3 months ago (2015-09-08 16:52:01 UTC) #6
dglazkov
lgtm
5 years, 3 months ago (2015-09-08 17:39:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309243006/1
5 years, 3 months ago (2015-09-08 18:53:54 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 20:04:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201928

Powered by Google App Engine
This is Rietveld 408576698