Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/web/tests/sim/SimDisplayItemList.cpp

Issue 1329553004: Add a FOUC painting test. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Clean up. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "config.h"
6 #include "web/tests/sim/SimDisplayItemList.h"
7
8 #include "third_party/skia/include/core/SkPicture.h"
9
10 namespace blink {
11
12 SimDisplayItemList::SimDisplayItemList()
13 : m_didDrawText(false)
14 , m_drawCount(0)
15 {
16 }
17
18 void SimDisplayItemList::appendDrawingItem(const SkPicture* picture)
19 {
20 // There's not much we can tell about a picture, but we can tell if it
jbroman 2015/09/06 17:00:51 It's possible to play a picture back to a mock SkC
esprehn 2015/09/06 20:27:58 Using gtest mocks? The SkCanvas isn't virtual. Do
esprehn 2015/09/06 21:17:56 Oh I see all the onDraw* virtual methods that the
jbroman 2015/09/07 00:52:37 Yeah. Here's a simple example of this in a test (t
21 // contains text. Ideally paint slimming would have a higher level
22 // display list (or special GraphicsContext) so unit tests could query
23 // what kind of things were painted.
24 m_didDrawText |= picture->hasText();
25 m_drawCount += picture->approximateOpCount();
26 }
27
28 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698