Issue 1329083004: Comments: note existance of SkImage::newShader next to CreateBitmapShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1329083004: Comments: note existance of SkImage::newShader next to CreateBitmapShader (Closed)

Created:
5 years, 3 months ago by hal.canary

Modified:
5 years, 3 months ago

Reviewers:
reed1

CC:
reviews_skia.org, viktorl

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Comments: note existance of SkImage::newShader next to CreateBitmapShader Committed: https://skia.googlesource.com/skia/+/a5f46e18212e8f4812ae25fda3acc6a5217613b1

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	include/core/SkShader.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329083004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329083004/1

5 years, 3 months ago (2015-09-08 14:07:34 UTC) #6

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 14:12:29 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a5f46e18212e8f4812ae25fda3acc6a5217613b1

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages