Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1328823002: GN: Use interface jars in the classpath to speed up compiling (a little) (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ijar2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use interface jars in the classpath to speed up compiling (a little) Rebuilding chrome_java before change: real 1m0.108s user 7m44.609s sys 0m27.630s Rebuilding chrome_java after change: real 0m57.893s user 7m22.493s sys 0m21.224s BUG=527632 Committed: https://crrev.com/6d6c9ac82e8f06abb047501d37b95cae145a727c Cr-Commit-Position: refs/heads/master@{#347405}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : prefix local var #

Patch Set 4 : .interface.jar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M build/android/BUILD.gn View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M build/android/gyp/javac.py View 1 2 3 4 chunks +20 lines, -7 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 3 6 chunks +12 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
agrieve
5 years, 3 months ago (2015-09-03 19:59:48 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-03 20:12:23 UTC) #3
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-03 20:12:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328823002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328823002/50001
5 years, 3 months ago (2015-09-04 13:55:49 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 3 months ago (2015-09-04 14:57:42 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 14:58:22 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6d6c9ac82e8f06abb047501d37b95cae145a727c
Cr-Commit-Position: refs/heads/master@{#347405}

Powered by Google App Engine
This is Rietveld 408576698