Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328793002: Don't rely on resolution for enqueuing (Closed)

Created:
5 years, 3 months ago by ahe
Modified:
5 years, 3 months ago
Reviewers:
Johnni Winther
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -84 lines) Patch
M pkg/fletchc/lib/src/dynamic_call_enqueuer.dart View 8 chunks +31 lines, -76 lines 3 comments Download
M pkg/fletchc/lib/src/fletch_enqueuer.dart View 5 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ahe
https://codereview.chromium.org/1328793002/diff/40001/pkg/fletchc/lib/src/dynamic_call_enqueuer.dart File pkg/fletchc/lib/src/dynamic_call_enqueuer.dart (left): https://codereview.chromium.org/1328793002/diff/40001/pkg/fletchc/lib/src/dynamic_call_enqueuer.dart#oldcode117 pkg/fletchc/lib/src/dynamic_call_enqueuer.dart:117: /// 1. Implements `operator ==` (and is thus suitable ...
5 years, 3 months ago (2015-09-03 15:07:10 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/1328793002/diff/40001/pkg/fletchc/lib/src/dynamic_call_enqueuer.dart File pkg/fletchc/lib/src/dynamic_call_enqueuer.dart (left): https://codereview.chromium.org/1328793002/diff/40001/pkg/fletchc/lib/src/dynamic_call_enqueuer.dart#oldcode117 pkg/fletchc/lib/src/dynamic_call_enqueuer.dart:117: /// 1. Implements `operator ==` (and is thus ...
5 years, 3 months ago (2015-09-03 16:21:17 UTC) #5
ahe
Thank you, Johnni! https://codereview.chromium.org/1328793002/diff/40001/pkg/fletchc/lib/src/dynamic_call_enqueuer.dart File pkg/fletchc/lib/src/dynamic_call_enqueuer.dart (left): https://codereview.chromium.org/1328793002/diff/40001/pkg/fletchc/lib/src/dynamic_call_enqueuer.dart#oldcode117 pkg/fletchc/lib/src/dynamic_call_enqueuer.dart:117: /// 1. Implements `operator ==` (and ...
5 years, 3 months ago (2015-09-03 16:24:09 UTC) #6
ahe
5 years, 3 months ago (2015-09-03 16:36:55 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) manually as
12c2e4b64f0e24570e80aaddcea66dd516e5f4d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698