Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: pkg/fletchc/lib/src/fletch_enqueuer.dart

Issue 1328793002: Don't rely on resolution for enqueuing (Closed) Base URL: git@github.com:dart-lang/fletch.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/fletchc/lib/src/fletch_enqueuer.dart
diff --git a/pkg/fletchc/lib/src/fletch_enqueuer.dart b/pkg/fletchc/lib/src/fletch_enqueuer.dart
index 2186a653733eac67d636157e516df19373cbfb48..8a3145951e14a8961cd539b58bb4559aa0330f9f 100644
--- a/pkg/fletchc/lib/src/fletch_enqueuer.dart
+++ b/pkg/fletchc/lib/src/fletch_enqueuer.dart
@@ -21,6 +21,7 @@ import 'package:compiler/src/dart2jslib.dart' show
import 'package:compiler/src/universe/universe.dart' show
CallStructure,
+ Selector,
Universe,
UniverseSelector;
@@ -79,10 +80,6 @@ class FletchEnqueueTask extends CompilerTask implements EnqueueTask {
super(compiler) {
codegen.task = this;
resolution.task = this;
- if (codegen is! TransitionalFletchEnqueuer) {
- FletchEnqueuer fletchEnqueuer = codegen;
- fletchEnqueuer.dynamicCallEnqueuer.task = this;
- }
codegen.nativeEnqueuer = compiler.backend.nativeCodegenEnqueuer(codegen);
resolution.nativeEnqueuer =
@@ -157,7 +154,7 @@ class TransitionalFletchEnqueuer extends CodegenEnqueuer
Queue<Element> get _pendingEnqueuedElements => notImplemented;
- void _enqueueElement(Element element) => notImplemented;
+ void _enqueueElement(element, selector) => notImplemented;
}
class FletchEnqueuer extends EnqueuerMixin implements CodegenEnqueuer {
@@ -221,12 +218,17 @@ class FletchEnqueuer extends EnqueuerMixin implements CodegenEnqueuer {
dynamicCallEnqueuer.registerInstantiatedType(type);
}
+ // TODO(ahe): Remove this method.
void registerStaticUse(Element element) {
- _enqueueElement(element);
+ _enqueueElement(
+ element,
+ new UniverseSelector(new Selector.fromElement(element), null));
}
+ // TODO(ahe): Remove this method.
void addToWorkList(Element element) {
- _enqueueElement(element);
+ _enqueueElement(
+ element, new UniverseSelector(new Selector.fromElement(element), null));
}
void forEach(void f(WorkItem work)) {
@@ -275,7 +277,7 @@ class FletchEnqueuer extends EnqueuerMixin implements CodegenEnqueuer {
dynamicCallEnqueuer.enqueueSelector(selector);
}
- void _enqueueElement(Element element) {
+ void _enqueueElement(Element element, UniverseSelector selector) {
if (_enqueuedElements.add(element)) {
_pendingEnqueuedElements.addLast(element);
newlyEnqueuedElements.add(element);

Powered by Google App Engine
This is Rietveld 408576698