Issue 132833002: Improves GN's make_global_settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132833002: Improves GN's make_global_settings (Closed)

Created:
6 years, 11 months ago by brettw

Modified:
6 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improves GN's make_global_settings This makes make_global_settings closer to the GYP version. Previously it had relied on GYP concatenating two lists when running with goma, but it doesn't actually behave this way, resulting in unexpected output. TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244104

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove print #

Patch Set 4 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -33 lines)			Patch
M	build/config/compiler/BUILD.gn	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	build/toolchain/android/BUILD.gn	View	1 2	3 chunks	+11 lines, -14 lines	0 comments	Download
M	build/toolchain/clang.gni	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	build/toolchain/goma.gni	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	build/toolchain/linux/BUILD.gn	View		2 chunks	+10 lines, -11 lines	0 comments	Download
M	build/toolchain/mac/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/132833002/170001

6 years, 11 months ago (2014-01-10 00:46:19 UTC) #3

Message was sent while issue was closed.

Change committed as 244104

Expand Messages | Collapse Messages