Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/goma.gni

Issue 132833002: Improves GN's make_global_settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/clang.gni ('k') | build/toolchain/linux/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/goma.gni
diff --git a/build/toolchain/goma.gni b/build/toolchain/goma.gni
index 15cb5427b93b9ddd42f9aa2a12a7a24a4f4c2e75..66348a96fce2de38b34ddcd8b976ed3a1d0b5230 100644
--- a/build/toolchain/goma.gni
+++ b/build/toolchain/goma.gni
@@ -42,10 +42,8 @@ if (use_goma && goma_dir == "") {
if (use_goma) {
# Define the toolchain for the GYP build when using goma.
make_goma_global_settings =
- "'make_global_settings': [" +
"['CC_wrapper', '$goma_dir/gomacc']," +
"['CXX_wrapper', '$goma_dir/gomacc']," +
"['CC.host_wrapper', '$goma_dir/gomacc']," +
- "['CXX.host_wrapper', '$goma_dir/gomacc']," +
- "],"
+ "['CXX.host_wrapper', '$goma_dir/gomacc'],"
}
« no previous file with comments | « build/toolchain/clang.gni ('k') | build/toolchain/linux/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698