Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3499)

Unified Diff: build/toolchain/linux/BUILD.gn

Issue 132833002: Improves GN's make_global_settings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/goma.gni ('k') | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/linux/BUILD.gn
diff --git a/build/toolchain/linux/BUILD.gn b/build/toolchain/linux/BUILD.gn
index 393288b85817c537716eba9081b5313ec298548c..d74457386ab5e7a11a2de60eaf13e048c7cb604e 100644
--- a/build/toolchain/linux/BUILD.gn
+++ b/build/toolchain/linux/BUILD.gn
@@ -13,9 +13,9 @@ if (is_gyp) {
# any given build.
if (is_clang) {
# Set the GYP header for all toolchains when running under Clang.
- gyp_header = make_clang_global_settings
+ make_global_settings = make_clang_global_settings
} else {
- gyp_header = ""
+ make_global_settings = ""
}
if (use_goma) {
@@ -27,15 +27,14 @@ if (is_gyp) {
# GYP will interpret the file once for each generator, so we have to write
# this condition into the GYP file since the user could have more than one
# generator set.
- if (gyp_header == "") {
- gyp_header +=
- "'conditions':" +
- "['\"<(GENERATOR)\"==\"ninja\"', {" +
- make_goma_global_settings +
- "}],"
- } else {
- gyp_header += make_goma_global_settings
- }
+ gyp_header =
+ "'conditions':" +
+ "['\"<(GENERATOR)\"==\"ninja\"', { 'make_global_settings': [" +
+ make_global_settings +
+ make_goma_global_settings +
+ "]}],"
+ } else {
+ gyp_header = "'make_global_settings': [" + make_global_settings + "],"
}
}
« no previous file with comments | « build/toolchain/goma.gni ('k') | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698