Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1328223002: Avoid a SVG property list-induced leak (Oilpan). (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid a SVG property list-induced leak (Oilpan). Address animations/svg-attribute-interpolation/svg-d-interpolation.html leak. R=haraken,kouhei BUG=528275 Committed: https://crrev.com/e4345b102c31a9adb5ce02f7df4cf97cd86cd483 git-svn-id: svn://svn.chromium.org/blink/trunk@202067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M Source/core/svg/SVGPathSeg.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSeg.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSegList.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSegList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/properties/SVGProperty.h View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
kouhei (in TOK)
lgtm
5 years, 3 months ago (2015-09-08 13:27:07 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-08 14:06:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328223002/1
5 years, 3 months ago (2015-09-10 14:38:14 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/102254)
5 years, 3 months ago (2015-09-10 16:38:16 UTC) #7
sof
let's send this along to address the leak, for now.
5 years, 3 months ago (2015-09-10 18:09:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328223002/1
5 years, 3 months ago (2015-09-10 18:09:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202067
5 years, 3 months ago (2015-09-10 19:18:57 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:12:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4345b102c31a9adb5ce02f7df4cf97cd86cd483

Powered by Google App Engine
This is Rietveld 408576698