Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: Source/core/svg/SVGPathSegList.h

Issue 1328223002: Avoid a SVG property list-induced leak (Oilpan). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGPathSeg.cpp ('k') | Source/core/svg/SVGPathSegList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 Base::append(passNewItem); 158 Base::append(passNewItem);
159 } 159 }
160 160
161 void updateListFromByteStream(); 161 void updateListFromByteStream();
162 void invalidateList(); 162 void invalidateList();
163 163
164 // FIXME: This pointer should be removed after SVGPathSeg has a tear-off. 164 // FIXME: This pointer should be removed after SVGPathSeg has a tear-off.
165 // 165 //
166 // SVGPathSegList is either owned by SVGAnimatedPath or SVGPathSegListTearOf f. 166 // SVGPathSegList is either owned by SVGAnimatedPath or SVGPathSegListTearOf f.
167 // Both keep |contextElement| alive, so this ptr is always valid. 167 // Both keep |contextElement| alive, so this ptr is always valid.
168 RawPtrWillBeMember<SVGPathElement> m_contextElement; 168 GC_PLUGIN_IGNORE("528275")
169 SVGPathElement* m_contextElement;
169 170
170 mutable OwnPtr<SVGPathByteStream> m_byteStream; 171 mutable OwnPtr<SVGPathByteStream> m_byteStream;
171 bool m_listSyncedToByteStream; 172 bool m_listSyncedToByteStream;
172 }; 173 };
173 174
174 inline PassRefPtrWillBeRawPtr<SVGPathSegList> toSVGPathSegList(PassRefPtrWillBeR awPtr<SVGPropertyBase> passBase) 175 inline PassRefPtrWillBeRawPtr<SVGPathSegList> toSVGPathSegList(PassRefPtrWillBeR awPtr<SVGPropertyBase> passBase)
175 { 176 {
176 RefPtrWillBeRawPtr<SVGPropertyBase> base = passBase; 177 RefPtrWillBeRawPtr<SVGPropertyBase> base = passBase;
177 ASSERT(base->type() == SVGPathSegList::classType()); 178 ASSERT(base->type() == SVGPathSegList::classType());
178 return static_pointer_cast<SVGPathSegList>(base.release()); 179 return static_pointer_cast<SVGPathSegList>(base.release());
179 } 180 }
180 181
181 } // namespace blink 182 } // namespace blink
182 183
183 #endif 184 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGPathSeg.cpp ('k') | Source/core/svg/SVGPathSegList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698