Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: Source/core/svg/properties/SVGProperty.h

Issue 1328223002: Avoid a SVG property list-induced leak (Oilpan). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGPathSegList.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/properties/SVGProperty.h
diff --git a/Source/core/svg/properties/SVGProperty.h b/Source/core/svg/properties/SVGProperty.h
index cb2e630ee9b215748959c1ce9841c48442ae0568..7e6ab25378083e468517a2907187aacadd63770c 100644
--- a/Source/core/svg/properties/SVGProperty.h
+++ b/Source/core/svg/properties/SVGProperty.h
@@ -88,10 +88,7 @@ public:
m_ownerList = ownerList;
}
- DEFINE_INLINE_VIRTUAL_TRACE()
- {
- visitor->trace(m_ownerList);
- }
+ DEFINE_INLINE_VIRTUAL_TRACE() { }
protected:
explicit SVGPropertyBase(AnimatedPropertyType type)
@@ -103,7 +100,11 @@ protected:
private:
const AnimatedPropertyType m_type;
- RawPtrWillBeMember<SVGPropertyBase> m_ownerList;
+ // Oilpan: the back reference to the owner should be a Member, but this can create
+ // cycles when SVG properties meet the off-heap InterpolationValue hierarchy.
+ // Not tracing it is safe, albeit an undesirable state of affairs.
+ GC_PLUGIN_IGNORE("528275")
+ SVGPropertyBase* m_ownerList;
};
}
« no previous file with comments | « Source/core/svg/SVGPathSegList.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698