Issue 132793008: Revert 248878 "Merge 248802 "Remove build references to third_pa..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132793008: Revert 248878 "Merge 248802 "Remove build references to third_pa..." (Closed)

Created:
6 years, 10 months ago by dxie

Modified:
6 years, 10 months ago

Reviewers:
dxie

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1823/src/

Visibility:
Public.

Revert 248878 "Merge 248802 "Remove build references to third_pa..." > Merge 248802 "Remove build references to third_party/cygwin" > > > Remove build references to third_party/cygwin > > > > There's test running dependencies in blink and buildbot, > > so the directory/DEPS can't be removed right now. For the > > time being, remove the build related entries. > > > > R=maruel@chromium.org, thakis@chromium.org > > BUG=123026 > > TEST=remove from DEPS and .DEPS.git, delete HKCU\Software\Cygnus Solutions\... and build successfully. > > > > Review URL: https://codereview.chromium.org/149063008 > > TBR=scottmg@chromium.org > > Review URL: https://codereview.chromium.org/153393003 TBR=dxie@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248879

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, --3 lines)			Patch
M	DEPS	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	build/win/setup_cygwin_mount.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser_tests.isolate	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chrome/tools/build/win/version.bat	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/tools/build/win/version.rules	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/content_browsertests.isolate	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r248879.