Issue 153393003: Merge 248802 "Remove build references to third_party/cygwin"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153393003: Merge 248802 "Remove build references to third_party/cygwin" (Closed)

Created:
6 years, 10 months ago by dxie

Modified:
6 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/branches/1823/src/

Visibility:
Public.

Merge 248802 "Remove build references to third_party/cygwin" > Remove build references to third_party/cygwin > > There's test running dependencies in blink and buildbot, > so the directory/DEPS can't be removed right now. For the > time being, remove the build related entries. > > R=maruel@chromium.org, thakis@chromium.org > BUG=123026 > TEST=remove from DEPS and .DEPS.git, delete HKCU\Software\Cygnus Solutions\... and build successfully. > > Review URL: https://codereview.chromium.org/149063008 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248878

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -119 lines)			Patch
M	DEPS	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	build/common.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	build/win/setup_cygwin_mount.py	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	chrome/browser_tests.isolate	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/tools/build/win/version.bat	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	chrome/tools/build/win/version.rules	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	content/content_browsertests.isolate	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

scottmg

6 years, 10 months ago (2014-02-05 15:54:34 UTC) #4

Message was sent while issue was closed.

On 2014/02/05 15:53:56, scottmg wrote:
> Why did this need to be merged?

Oh, I see the merge was reverted now.