Remove build references to third_party/cygwin

Remove build references to third_party/cygwin

There's test running dependencies in blink and buildbot,
so the directory/DEPS can't be removed right now. For the
time being, remove the build related entries.

R=maruel@chromium.org, thakis@chromium.org
BUG=123026
TEST=remove from DEPS and .DEPS.git, delete HKCU\Software\Cygnus Solutions\... and build successfully.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248802

[Nico, 2014-01-30 04:53:18]

Does this really remove third_party/cygwin ? Looks like there are still a few
references to setup_mount.bat ?

[scottmg, 2014-01-30 05:24:34]

On 2014/01/30 04:53:18, Nico wrote:
> Does this really remove third_party/cygwin ? Looks like there are still a few
> references to setup_mount.bat ?

You're right! I didn't even think to look places other than gyp, but we're
sneakier than I thought. I'll remove those first.

[scottmg, 2014-01-31 18:03:14]

Getting rid of the directory looks increasingly difficult, so just remove the
build-related references for now.

[Nico, 2014-01-31 23:24:30]

https://codereview.chromium.org/149063008/diff/130001/DEPS
File DEPS (left):

https://codereview.chromium.org/149063008/diff/130001/DEPS#oldcode646
DEPS:646: "action": ["python", "src/build/win/setup_cygwin_mount.py",
"--win-only"],
And this isn't needed for the lighttpd stuff?

[Nico, 2014-01-31 23:25:53]

https://codereview.chromium.org/149063008/diff/130001/chrome/browser_tests.is...
File chrome/browser_tests.isolate (left):

https://codereview.chromium.org/149063008/diff/130001/chrome/browser_tests.is...
chrome/browser_tests.isolate:128: '../third_party/cygwin/setup_mount.bat',
Why was this here? Some fake web server in browser_tests too?

[scottmg, 2014-02-01 00:10:52]

On 2014/01/31 23:24:30, Nico wrote:
> https://codereview.chromium.org/149063008/diff/130001/DEPS
> File DEPS (left):
> 
> https://codereview.chromium.org/149063008/diff/130001/DEPS#oldcode646
> DEPS:646: "action": ["python", "src/build/win/setup_cygwin_mount.py",
> "--win-only"],
> And this isn't needed for the lighttpd stuff?

I don't think so, but it's possible it was depending on that existing. If
necessary, I can add a direct run of setup_mount.bat somewhere.

[scottmg, 2014-02-01 00:12:22]

On 2014/01/31 23:25:53, Nico wrote:
>
https://codereview.chromium.org/149063008/diff/130001/chrome/browser_tests.is...
> File chrome/browser_tests.isolate (left):
> 
>
https://codereview.chromium.org/149063008/diff/130001/chrome/browser_tests.is...
> chrome/browser_tests.isolate:128: '../third_party/cygwin/setup_mount.bat',
> Why was this here? Some fake web server in browser_tests too?


As far as I can tell it's unnecessary, the only external webserver I can find is
https://code.google.com/p/chromium/codesearch#chromium/src/net/test/spawned_t...
which is some python, not lighttpd or apache. Maybe the tryjobs will enlighten
me though.

[Nico, 2014-02-01 00:14:37]

lgtm, we'll see if it breaks something I guess :-)

[scottmg, 2014-02-01 00:20:12]

On 2014/02/01 00:10:52, scottmg wrote:
> On 2014/01/31 23:24:30, Nico wrote:
> > https://codereview.chromium.org/149063008/diff/130001/DEPS
> > File DEPS (left):
> > 
> > https://codereview.chromium.org/149063008/diff/130001/DEPS#oldcode646
> > DEPS:646: "action": ["python", "src/build/win/setup_cygwin_mount.py",
> > "--win-only"],
> > And this isn't needed for the lighttpd stuff?
> 
> I don't think so, but it's possible it was depending on that existing. If
> necessary, I can add a direct run of setup_mount.bat somewhere.

Perhaps should call that here:
https://code.google.com/p/chromium/codesearch#chromium/tools/build/slave/run_...

I think I'll preemptively patch that in since it might not otherwise be obvious
for a long time (i.e. until a windows bot is re-imaged).
https://codereview.chromium.org/147313006

[Nico, 2014-02-01 00:24:21]

On Fri, Jan 31, 2014 at 4:20 PM, <scottmg@chromium.org> wrote:

> On 2014/02/01 00:10:52, scottmg wrote:
>
>> On 2014/01/31 23:24:30, Nico wrote:
>> > https://codereview.chromium.org/149063008/diff/130001/DEPS
>> > File DEPS (left):
>> >
>> > https://codereview.chromium.org/149063008/diff/130001/DEPS#oldcode646
>> > DEPS:646: "action": ["python", "src/build/win/setup_cygwin_mount.py",
>> > "--win-only"],
>> > And this isn't needed for the lighttpd stuff?
>>
>
>  I don't think so, but it's possible it was depending on that existing. If
>> necessary, I can add a direct run of setup_mount.bat somewhere.
>>
>
> Perhaps should call that here:
> https://code.google.com/p/chromium/codesearch#chromium/
> tools/build/slave/run_webserver.bat&q=run_webserver.
> bat&sq=package:chromium&l=1
>
> I think I'll preemptively patch that in since it might not otherwise be
> obvious
> for a long time (i.e. until a windows bot is re-imaged).
>

We should let some windows machine get re-imaged right after this lands, to
make sure it still works.


> https://codereview.chromium.org/147313006
>
> https://codereview.chromium.org/149063008/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2014-02-04 00:46:59]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-04 00:49:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149063008/130001

[commit-bot: I haz the power, 2014-02-04 01:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 01:13:06]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[scottmg, 2014-02-04 01:19:08]

+maruel for *.isolate owners.

[M-A Ruel, 2014-02-04 01:23:50]

https://codereview.chromium.org/149063008/diff/130001/chrome/browser_tests.is...
File chrome/browser_tests.isolate (left):

https://codereview.chromium.org/149063008/diff/130001/chrome/browser_tests.is...
chrome/browser_tests.isolate:128: '../third_party/cygwin/setup_mount.bat',
On 2014/01/31 23:25:53, Nico wrote:
> Why was this here? Some fake web server in browser_tests too?

I don't recall.

https://codereview.chromium.org/149063008/diff/130001/content/content_browser...
File content/content_browsertests.isolate (right):

https://codereview.chromium.org/149063008/diff/130001/content/content_browser...
content/content_browsertests.isolate:93: # The directory below is only needed
for
I think you can remove the whole section. When someone wants to reenable this
test and it's not needing this anymore, this comment won't be updated. So just
get rid of this.

[scottmg, 2014-02-04 01:28:39]

https://codereview.chromium.org/149063008/diff/130001/content/content_browser...
File content/content_browsertests.isolate (right):

https://codereview.chromium.org/149063008/diff/130001/content/content_browser...
content/content_browsertests.isolate:93: # The directory below is only needed
for
On 2014/02/04 01:23:51, M-A Ruel wrote:
> I think you can remove the whole section. When someone wants to reenable this
> test and it's not needing this anymore, this comment won't be updated. So just
> get rid of this.

Done.

[M-A Ruel, 2014-02-04 01:32:14]

lgtm but incomplete upload.

[scottmg, 2014-02-04 04:26:06]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-04 04:26:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149063008/460001

[commit-bot: I haz the power, 2014-02-04 05:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 05:33:12]

Retried try job too often on linux_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[scottmg, 2014-02-04 16:49:47]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-04 16:51:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149063008/460001

[commit-bot: I haz the power, 2014-02-04 18:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 18:48:46]

Retried try job too often on ios_dbg_simulator for step(s) url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[scottmg, 2014-02-04 18:52:52]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-04 18:54:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/149063008/460001

[commit-bot: I haz the power, 2014-02-04 22:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 22:51:47]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[scottmg, 2014-02-04 23:00:44]

Committed patchset #9 manually as r248802 (presubmit successful).