[Chromecast] Raises CastService creation to CastContentBrowserClient.

[Chromecast] Raises CastService creation to CastContentBrowserClient.

This is a first step toward resolving the chromecast/service/ --> content/
dependency by removing the link-time creation path in CastService.

Also, removes some code that has become dead via refactoring across the
internal/external repository boundary.

R=slan@chromium.org,halliwell@chromium.org,byungchul@chromium.org
BUG=None

Committed: https://crrev.com/2133b4589aa40225f9abd68b151f2a8359b9c8d0
Cr-Commit-Position: refs/heads/master@{#346936}

[byungchul, 2015-09-01 23:18:01]

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_bro...
File chromecast/browser/cast_browser_main_parts.cc (left):

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:340:
cast_browser_process_->metrics_service_client(),
Remove only metrics service client because others are accessed by other places?
Wonder which singleton is better between CastService and CastBrowserProcess.

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_con...
File chromecast/browser/cast_content_browser_client.cc (left):

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_con...
chromecast/browser/cast_content_browser_client.cc:73: return
std::vector<scoped_refptr<content::BrowserMessageFilter>>();
I guess some headers are not used after removing this.

https://codereview.chromium.org/1327723002/diff/1/chromecast/renderer/cast_co...
File chromecast/renderer/cast_content_renderer_client.cc (left):

https://codereview.chromium.org/1327723002/diff/1/chromecast/renderer/cast_co...
chromecast/renderer/cast_content_renderer_client.cc:113: }
remove unused header files.

[gunsch, 2015-09-01 23:42:49]

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_bro...
File chromecast/browser/cast_browser_main_parts.cc (left):

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_bro...
chromecast/browser/cast_browser_main_parts.cc:340:
cast_browser_process_->metrics_service_client(),
On 2015/09/01 23:18:01, byungchul wrote:
> Remove only metrics service client because others are accessed by other
places?
> Wonder which singleton is better between CastService and CastBrowserProcess.

Hmm, good question. I'd like to eventually eliminate BrowserContext and
MetricsServiceClient from being passed to ChromecastService, since both are
content/ dependencies.

I think originally MetricsServiceClient was added for CastServiceAndroid, which
is no longer necessary. So that's why I removed it.

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_con...
File chromecast/browser/cast_content_browser_client.cc (left):

https://codereview.chromium.org/1327723002/diff/1/chromecast/browser/cast_con...
chromecast/browser/cast_content_browser_client.cc:73: return
std::vector<scoped_refptr<content::BrowserMessageFilter>>();
On 2015/09/01 23:18:01, byungchul wrote:
> I guess some headers are not used after removing this.

I don't know which ones. <vector> wasn't included, scoped_refptr and
content::BrowserMessageFilter are both referenced in this file still.

https://codereview.chromium.org/1327723002/diff/1/chromecast/renderer/cast_co...
File chromecast/renderer/cast_content_renderer_client.cc (left):

https://codereview.chromium.org/1327723002/diff/1/chromecast/renderer/cast_co...
chromecast/renderer/cast_content_renderer_client.cc:113: }
On 2015/09/01 23:18:01, byungchul wrote:
> remove unused header files.

Done.

[byungchul, 2015-09-02 00:44:41]

lgtm

[slan, 2015-09-02 02:36:11]

lgtm

lgtm

[halliwell, 2015-09-02 02:38:35]

On 2015/09/02 02:36:11, slan wrote:
> lgtm
> 
> lgtm

lgtm

[gunsch, 2015-09-02 16:31:16]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-09-02 16:31:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1327723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1327723002/20001

[commit-bot: I haz the power, 2015-09-02 16:36:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-02 16:37:18]

Patchset 2 (id:??) landed as
https://crrev.com/2133b4589aa40225f9abd68b151f2a8359b9c8d0
Cr-Commit-Position: refs/heads/master@{#346936}