Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: chromecast/browser/service/cast_service.h

Issue 1327723002: [Chromecast] Raises CastService creation to CastContentBrowserClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: removed unnecessary include Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | chromecast/browser/service/cast_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/service/cast_service.h
diff --git a/chromecast/browser/service/cast_service.h b/chromecast/browser/service/cast_service.h
index e10ac39f254731396acb0e63aab373f2af351a01..d549885a84bdb44b725d4a1f586e39964e333b86 100644
--- a/chromecast/browser/service/cast_service.h
+++ b/chromecast/browser/service/cast_service.h
@@ -25,24 +25,8 @@ class URLRequestContextGetter;
namespace chromecast {
-namespace metrics {
-class CastMetricsServiceClient;
-}
-
class CastService {
public:
- // Create() takes a separate url request context getter because the request
- // context getter obtained through the browser context might not be
- // appropriate for the url requests made by the cast service/reciever.
- // For example, on Chromecast, it is needed to pass in a system url request
- // context getter that would set the request context for NSS, which the main
- // getter doesn't do.
- static scoped_ptr<CastService> Create(
- content::BrowserContext* browser_context,
- PrefService* pref_service,
- metrics::CastMetricsServiceClient* metrics_service_client,
- net::URLRequestContextGetter* request_context_getter);
-
virtual ~CastService();
// Initializes/finalizes the cast service.
@@ -55,8 +39,7 @@ class CastService {
protected:
CastService(content::BrowserContext* browser_context,
- PrefService* pref_service,
- metrics::CastMetricsServiceClient* metrics_service_client);
+ PrefService* pref_service);
// Implementation-specific initialization. Initialization of cast service's
// sub-components, and anything that requires IO operations should go here.
@@ -79,14 +62,10 @@ class CastService {
content::BrowserContext* browser_context() const { return browser_context_; }
PrefService* pref_service() const { return pref_service_; }
- metrics::CastMetricsServiceClient* metrics_service_client() const {
- return metrics_service_client_;
- }
private:
content::BrowserContext* const browser_context_;
PrefService* const pref_service_;
- metrics::CastMetricsServiceClient* const metrics_service_client_;
bool stopped_;
const scoped_ptr<base::ThreadChecker> thread_checker_;
« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | chromecast/browser/service/cast_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698