[Chromecast] Raises CastService creation to CastContentBrowserClient.

chromecast/browser/cast_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_browser_main_parts.h"
 
 #include <string>
 #if !defined(OS_ANDROID)
 #include <signal.h>
 #include <sys/prctl.h>
 #endif
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/run_loop.h"
 #include "base/thread_task_runner_handle.h"
 #include "cc/base/switches.h"
 #include "chromecast/base/cast_paths.h"
 #include "chromecast/base/cast_sys_info_util.h"
 #include "chromecast/base/chromecast_switches.h"
 #include "chromecast/base/metrics/cast_metrics_helper.h"
 #include "chromecast/base/metrics/grouped_histogram.h"
 #include "chromecast/browser/cast_browser_context.h"
 #include "chromecast/browser/cast_browser_process.h"
+#include "chromecast/browser/cast_content_browser_client.h"
 #include "chromecast/browser/cast_net_log.h"
 #include "chromecast/browser/devtools/remote_debugging_server.h"
 #include "chromecast/browser/metrics/cast_metrics_prefs.h"
 #include "chromecast/browser/metrics/cast_metrics_service_client.h"
 #include "chromecast/browser/pref_service_helper.h"
 #include "chromecast/browser/service/cast_service.h"
 #include "chromecast/browser/url_request_context_factory.h"
 #include "chromecast/common/platform_client_auth.h"
 #include "chromecast/media/base/key_systems_common.h"
 #include "chromecast/media/base/media_message_loop.h"
@@ skipping 289 matching lines @@
     LOG(ERROR) << "PlatformClientAuth::Initialize failed.";
 
   cast_browser_process_->SetRemoteDebuggingServer(
       make_scoped_ptr(new RemoteDebuggingServer()));
 
   media::MediaMessageLoop::GetTaskRunner()->PostTask(
       FROM_HERE,
       base::Bind(&media::CastMediaShlib::Initialize, cmd_line->argv()));
   ::media::InitializeMediaLibrary();
 
-  cast_browser_process_->SetCastService(CastService::Create(
-      cast_browser_process_->browser_context(),
-      cast_browser_process_->pref_service(),
-      cast_browser_process_->metrics_service_client(),

[byungchul, 2015/09/01 23:18:01]

Remove only metrics service client because others are accessed by other places?
Wonder which singleton is better between CastService and CastBrowserProcess.

[gunsch, 2015/09/01 23:42:49]

Hmm, good question. I'd like to eventually eliminate BrowserContext and
MetricsServiceClient from being passed to ChromecastService, since both are
content/ dependencies.

I think originally MetricsServiceClient was added for CastServiceAndroid, which
is no longer necessary. So that's why I removed it.

-      url_request_context_factory_->GetSystemGetter()));
+  cast_browser_process_->SetCastService(
+      cast_browser_process_->browser_client()->CreateCastService(
+          cast_browser_process_->browser_context(),
+          cast_browser_process_->pref_service(),
+          url_request_context_factory_->GetSystemGetter()));
   cast_browser_process_->cast_service()->Initialize();
 
   // Initializing metrics service and network delegates must happen after cast
   // service is intialized because CastMetricsServiceClient and
   // CastNetworkDelegate may use components initialized by cast service.
   cast_browser_process_->metrics_service_client()
       ->Initialize(cast_browser_process_->cast_service());
   url_request_context_factory_->InitializeNetworkDelegates();
 
   cast_browser_process_->cast_service()->Start();
@@ skipping 41 matching lines @@
 #if defined(USE_AURA)
   aura::Env::DeleteInstance();
 #endif
 
   DeregisterKillOnAlarm();
 #endif
 }
 
 }  // namespace shell
 }  // namespace chromecast